Conversation
gangelo
added
the
inherited proofing
gangelo
force-pushed
the
lg-7602-pull-va-ip-data-and-store-it-in-session-controller-and-flow-state
branch
2 times, most recently
from
06a90b6 to
bcd141b
Compare
gangelo
commented
Sep 23, 2022
app/services/idv/steps/inherited_proofing/user_pii_retrievable.rb
Outdated
Show resolved
Hide resolved
jmhooper
approved these changes
Sep 23, 2022
Specifically, obtaining user PII from the service provider and flow state support, including session massaging in preparation for IDV unattended work fllow. changelog: Upcoming Features, Inherited Proofing, Pull VA IP Data and Store It In Session (LG-7602)
This sets up session for the subsequent Inherited Proofing (IP) work flow/flow steps.
In order to proof our Inherited Proofing user: NOTE: the use of InheritedProofingConcern #inherited_proofing_service, members via its inclusion in the InheritedProofingController. Add delegations needed for conveinient access to controller and idv_session from InheritedProofingBaseStep so that we have these in any Flow Step we need them.
gangelo
force-pushed
the
lg-7602-pull-va-ip-data-and-store-it-in-session-controller-and-flow-state
branch
4 times, most recently
from
7638e2c to
6737bf8
Compare
This mixin provides a simple means to store user pii into the flow_session[:pii_from_user] and manage idv_session session data in preparation for IDV workflow handoff.
To session. Consume previously added UserPiiManagable mixin and 1) Save the user pii to session in the #call method 2) Return the FormResponse from the Service Provider API call to obtain user pii, so that it can be processed by the base class e.g. merged in with the Flow Step Form FormResponse and passed to analytics properly/perform error handling..
The Inherited Proofing (IP) flow steps now need current_user to be populated as would be the case in a real-life scenario as the user would have created an account and logged in before being redirected to the IP work flow. This change sets up current_user to create a real-live scenario. Specs also test to make sure flow steps are working regardless of the IdentityConfig.store.va_inherited_proofing_mock_enabled setting, although this may be sufficiently covered by the spec/controllers/concerns/inherited_proofing_concern_spec.rb specs.
gangelo
force-pushed
the
lg-7602-pull-va-ip-data-and-store-it-in-session-controller-and-flow-state
branch
from
6737bf8 to
412b32b
Compare
gangelo
deleted the
lg-7602-pull-va-ip-data-and-store-it-in-session-controller-and-flow-state
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATTENTION: This branch is blocked/will fail until this PR is approved/merged
https://cm-jira.usa.gov/browse/LG-7602
3 of 3.
This is a supporting change for the LG-7602 feature for Inherited Proofing (IP).
The user's PII needs to be obtained from the Service Provider in our Inherited
Proofing process Flow Steps so that we can process the data and put it into session in such a way so that we can hand the rest of the proofing process to the current IDV workflow in a seamless manner.
These changes ensure we can do the following in both our IP controller and/or IP Flow Steps: