LG-7602 Pull VA IP Data and Store It In Session (InheritedProofingConcern refactor) 2 of 3

[gangelo]

https://cm-jira.usa.gov/browse/LG-7602

2 of 3.

This is a supporting change for the LG-7602 feature for Inherited Proofing (IP).

The user's PII needs to be obtained from the Service Provider in our Inherited Proofing process Flow Steps. Identifying whether or not an Inherited Proofing SP request is in progress, needs access to the decorated_session, which currently takes place in the InheritedProofingConcern. It makes sense (for how), to serve up the Service Provider Services and Forms in this concern, since we can easily identify the Service Provider here also; we can think about placing this code in a SP Service and Form factory or something similar later.

changelog: Upcoming Features, Inherited Proofing, Pull VA IP Data and Store It In Session (LG-7602)

[jmhooper]

I don't think I see where you are going here. You are talking about adding the PII to the flow session, but the flow session is not directly available from anywhere this concern is included. The data will need to be added to the flow session within the context of the flow state machine.

[jmhooper]

I supposed what I am saying is wouldn't it make more sense to have this functionality built into the AgreementStep in the inherited proofing flow?

[gangelo]

Hi @jmhooper, thank you for your patience and time. I know ur busy...

...wouldn't it make more sense to have this functionality built into the AgreementStep in the inherited proofing flow?

Yes. This is what I'm doing; see below.

...The data will need to be added to the flow session within the context of the flow state machine.

Yes. This is what I am doing. All this will be in our AgreementStep flow step; I wouldn't expect you to see the big picture yet; you can follow that, here: PR 3 of 3. NOTE: the aforementioned PR build is failing because it is waiting on this PR to be merged.

Unfortunately (fortunately?) it was either this way, or stuff all this crap into a monster PR which I didn't want to torture anyone with lol.

cc @benjaminchait

[gangelo]

NOTE: The bulk of the changes here are due to the change in param sent to the Idv::InheritedProofing::Va::Service which now accepts { auth_code: <auth code> } whereas before, it was just auth_code.