Remove unused OpenID Connect Logout prevent_logout_redirect parameter#7001
Merged
mitchellhenke merged 1 commit intomainfrom Sep 22, 2022
Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/drop-prevent-logout-redirect-param
branch
from
3a324e5 to
af5cf94
Compare
orenyk
approved these changes
Sep 21, 2022
Contributor
orenyk
left a comment
orenyk
left a comment
There was a problem hiding this comment.
no idea what this was but if the spec pass I'm cool with it
mitchellhenke
force-pushed
the
mitchellhenke/drop-prevent-logout-redirect-param
branch
from
af5cf94 to
3b4ea03
Compare
…ect Logout prevent_logout_redirect parameter
mitchellhenke
force-pushed
the
mitchellhenke/drop-prevent-logout-redirect-param
branch
from
3b4ea03 to
a2bdc12
Compare
Contributor
Author
|
After trying to remove it, it seems like it is only used intended for use within feature specs for testing that the CSP headers are correct, so I have written a controller spec to cover that behavior and dropped the parameter and the CSP checks from those feature tests. |
mitchellhenke
deleted the
mitchellhenke/drop-prevent-logout-redirect-param
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was introduced by #3479 / LG-2441, but it's not clear what the intention was since the default action is to try rendering
index.htmlwhich doesn't exist so usingprevent_logout_redirectwill 404 currently.The parameter does not appear in:
So it seems safe to drop?