Update add_email to build its URL once and re-use it#7021
Merged
zachmargolis merged 1 commit intomainfrom Sep 26, 2022
Merged
Conversation
- Follow-up to #7019 to prevent similar bugs in the future [skip changelog]
zachmargolis
commented
Sep 22, 2022
| <center> | ||
| <%= link_to t('user_mailer.email_confirmation_instructions.link_text'), | ||
| add_email_confirmation_url( | ||
| _request_id: @request_id, |
Contributor
Author
There was a problem hiding this comment.
As far as I can tell, @request_id was never assigned... so it's always been nil in this email (it does get used in email_confirmation_instructions but that's a separate one)
Contributor
There was a problem hiding this comment.
Yeah, it would typically only be used to tie an SP auth request across browsers (register email on device1, confirm on device2, and still be able to continue to SP on device2) which doesn't super apply for adding an email address to an existing account.
mdiarra3
approved these changes
Sep 23, 2022
mitchellhenke
approved these changes
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip changelog]