LG-7643: Use deliver_later for in-person proofing results emails#7007
Merged
tomas-nava merged 1 commit intomainfrom Sep 22, 2022
Merged
LG-7643: Use deliver_later for in-person proofing results emails#7007tomas-nava merged 1 commit intomainfrom
tomas-nava merged 1 commit intomainfrom
Conversation
[skip changelog]
zachmargolis
approved these changes
Sep 22, 2022
| email_address, | ||
| enrollment: enrollment, | ||
| ).deliver_now_or_later(**mail_delivery_params) | ||
| ).deliver_later(**mail_delivery_params) |
Contributor
There was a problem hiding this comment.
should we update the lint to detect if we send params to deliver_now_or_later because those will get ignored?
Contributor
Author
There was a problem hiding this comment.
You mean if we pass params to deliver_now_or_later adding a warning that says something like "Parameters sent to deliver_now_or_later will be ignored if the deliver_mail_async flag is off"?
Contributor
There was a problem hiding this comment.
yup! (either that, or change the behavior inside deliver_now_or_later to use the params if they are passed)
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-7643
🛠 Changes
Uses
deliver_laterfor sending in-person proofing results emails instead ofdeliver_now_or_later.Why?
The
deliver_mail_asyncflag is off in production, but we want to send these emails after a delay. This change lets us do that without turning on the feature flag and causing all emails to be sent async.