Skip to content

Send the address to AAMVA#7011

Merged
kbighorse merged 9 commits intomainfrom
jmhooper-aamva-send-address
Sep 26, 2022
Merged

Send the address to AAMVA#7011
kbighorse merged 9 commits intomainfrom
jmhooper-aamva-send-address

Conversation

@jmhooper
Copy link
Contributor

This commit starts sending an address to AAMVA to validate. The verification still succeeds even if the address fails to match. This is because MVAs do not reliably perform address verification.

The address results are included in the hash returned from Proofing::Aamva::Responses::VerificationResponse#verification_results. These can be used downstream to allow the address to be used for validation when other proofers are unable to verify an address.

This commit starts sending an address to AAMVA to validate. The verification still succeeds even if the address fails to match. This is because MVAs do not reliably perform address verification.

The address results are included in the hash returned from `Proofing::Aamva::Responses::VerificationResponse#verification_results`. These can be used downstream to allow the address to be used for validation when other proofers are unable to verify an address.

[skip changelog]
last_name: applicant[:last_name],
dob: format_dob(applicant[:dob]),
state_id_data: format_state_id_data(applicant),
address1: applicant[:address1],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an address2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an address2 though I am just throwing the first line in for now since getting the 2nd in is a little complicated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To elaborate on this, the way the docs say to add the address to the request is to include an additional AddressDeliveryPointText field for address line 2, but only if there is an address line 2 present.

This means adding a little bit of extra logic to this class to handle that. We probably should do that but I'm keeping it simple for now to verify everything is working then we can come back around and handle the second address line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed 0386575 which is a little messy but does get address line 2 in there

@jmhooper
Copy link
Contributor Author

Okay, I think I have everything here. Should be ready for review

Copy link
Contributor

@kbighorse kbighorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@kbighorse kbighorse merged commit 399e9bb into main Sep 26, 2022
@kbighorse kbighorse deleted the jmhooper-aamva-send-address branch September 26, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants