Recompile Sass after exception when watching files#7009
Merged
Conversation
**Why**: So that a developer has an opportunity to fix a compilation error, and so that they're not confused when their changes are not reflected in the running application process. changelog: Internal, Build Tooling, Recompile CSS after error in local development
A bit clearer to interpret I think
mitchellhenke
approved these changes
Sep 22, 2022
Contributor
Author
|
I suspect this also has another benefit, which is that previously if someone added a new |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: So that a developer has an opportunity to fix a compilation error, and so that they're not confused when their changes are not reflected in the running application process.
Currently, if a developer is running
make runand introduces a syntax error to a stylesheet, the stylesheet build process will crash and never recover. The application will continue to run, however, causing confusion for the developer.Testing Instructions:
make runis running, observe the error in the console, and observe that the files are recompiled when the syntax error is fixed.