Conversation
**Why**: The code for this feature is slated for removal (LG-7386). Until that can be prioritized, it'd be useful to remove feature specs since they prolong the runtime of continuous integration builds
| @@ -8,7 +8,7 @@ | |||
| let(:fake_analytics) { FakeAnalytics.new } | |||
There was a problem hiding this comment.
IIRC this spec was here to maintain continuity between analytics events with FSMv2 being put together. Is there any value here with FSMv2 gone or could we remove this entire spec file?
There was a problem hiding this comment.
Personally, I still see value in asserting the events that we're expecting to have been logged during identity verification. I also like how this is implemented as a single canonical list, though I wouldn't mind if they were part of feature specs for the individual steps if we could trust that we did so exhaustively (I don't trust this, FWIW).
I had actually planned to expand this spec to include events logged during IAL1 authentication, as a regression spec for an issue I recently identified.
There was a problem hiding this comment.
+1 this spec is also useful if we wanted to refactor/change out FSM but keep the analytics events we have for consistency
changelog: Internal, Automated Testing, Improve performance of automated tests
3 participants
Why: The code for this feature is slated for removal (LG-7386). Until that can be prioritized, it'd be useful to remove feature specs since they prolong the runtime of continuous integration builds