LG-6896: Send 'fraud suspected' in-person proofing failed email by svalexander · Pull Request #7013 · 18F/identity-idp

svalexander · 2022-09-22T15:50:52Z

What: This pr sends a delayed failure email to a user who has completed in person proofing and fraudSuspected was true.

How: Added a new email template for this failure version as well as updated the usps job. Because there are now two versions of the failure email we need to check the value of status within handle_failed_status().
Note: fraudSuspected is a string according to the api documentation. There are some mock files (perhaps others) where it is a boolean, we should address this in another ticket.

Testing the email
To preview the email visit http://localhost:3000/rails/mailers/user_mailer/in_person_failed_fraud.html?locale=en
Or to trigger an email sent to mailcatcher update response on lines 86-88 to
response = JSON.parse(UspsInPersonProofing::Mock::Fixtures.request_failed_suspected_fraud_proofing_results_response)

En version

Es version

Fr version

…he process

app/jobs/get_usps_proofing_results_job.rb

…on/lg-6896-email-failed-fraud

…later

aduth

Couple minor comments, but LGTM overall 👍

aduth · 2022-09-26T15:18:18Z

app/jobs/get_usps_proofing_results_job.rb


    enrollment.update(status: :failed)
-    send_failed_email(enrollment.user, enrollment)
+    if response['fraudSuspected'] == true


Since the value is already a boolean, I think we could leave out the "equals" comparison.

Suggested change

if response['fraudSuspected'] == true

if response['fraudSuspected']

aduth · 2022-09-26T15:19:42Z

...person_proofing/mock/responses/request_failed_suspected_fraud_proofing_results_response.json

+    "status": "In-person failed",
+    "proofingPostOffice": "WILKES BARRE",
+    "proofingCity": "WILKES BARRE",
+    "proofingState": "PA",
+    "enrollmentCode": "2090002197604352",
+    "primaryIdType": "Uniformed Services identification card",
+    "transactionStartDateTime": "12/17/2020 033855",
+    "transactionEndDateTime": "12/17/2020 034055",
+    "secondaryIdType": "Deed of Trust",
+    "failureReason": "Clerk indicates that ID name or address does not match source data.",
+    "fraudSuspected": true,
+    "proofingConfirmationNumber": "350040248346707",
+    "ippAssuranceLevel": "1.5"
+  }
+


Minor whitespace suggestions:

Suggested change

"status": "In-person failed",

"proofingPostOffice": "WILKES BARRE",

"proofingCity": "WILKES BARRE",

"proofingState": "PA",

"enrollmentCode": "2090002197604352",

"primaryIdType": "Uniformed Services identification card",

"transactionStartDateTime": "12/17/2020 033855",

"transactionEndDateTime": "12/17/2020 034055",

"secondaryIdType": "Deed of Trust",

"failureReason": "Clerk indicates that ID name or address does not match source data.",

"fraudSuspected": true,

"proofingConfirmationNumber": "350040248346707",

"ippAssuranceLevel": "1.5"

}

"status": "In-person failed",

"proofingPostOffice": "WILKES BARRE",

"proofingCity": "WILKES BARRE",

"proofingState": "PA",

"enrollmentCode": "2090002197604352",

"primaryIdType": "Uniformed Services identification card",

"transactionStartDateTime": "12/17/2020 033855",

"transactionEndDateTime": "12/17/2020 034055",

"secondaryIdType": "Deed of Trust",

"failureReason": "Clerk indicates that ID name or address does not match source data.",

"fraudSuspected": true,

"proofingConfirmationNumber": "350040248346707",

"ippAssuranceLevel": "1.5"

}

…d failure email

…ud failure email

tomas-nava

some suggestions to fix failing tests!

tomas-nava · 2022-09-26T18:48:13Z

app/mailers/user_mailer.rb

+      )
+      mail(
+        to: email_address.email,
+        subject: t('user_mailer.in_person_failed_suspected_fraud.subject', app_name: APP_NAME),


Suggested change

subject: t('user_mailer.in_person_failed_suspected_fraud.subject', app_name: APP_NAME),

subject: t('user_mailer.in_person_failed_suspected_fraud.subject'),

There's no app_name variable in this translation.

tomas-nava · 2022-09-26T18:49:39Z

app/views/user_mailer/in_person_failed_fraud.html.erb

+  <%= t(
+        'user_mailer.in_person_failed_suspected_fraud.body.intro',
+        location: @presenter.location_name,
+        date: @presenter.formatted_verified_date,
+      ) %>


Suggested change

<%= t(

'user_mailer.in_person_failed_suspected_fraud.body.intro',

location: @presenter.location_name,

date: @presenter.formatted_verified_date,

) %>

<%= t(

'user_mailer.in_person_failed_suspected_fraud.body.intro',

app_name: APP_NAME,

location: @presenter.location_name,

date: @presenter.formatted_verified_date,

) %>

We should pass app_name here and use it instead of Login.gov in the translations

tomas-nava · 2022-09-26T18:50:34Z

config/locales/user_mailer/en.yml

+          href="%{help_center_url}">visit our Help Center</a> or reach out to
+          the agency you are trying to access.
+        intro: We understand that you were attempting to verify your identity through
+          Login.gov, however your identity could not be verified at the


Suggested change

Login.gov, however your identity could not be verified at the

%{app_name}, however your identity could not be verified at the

We should always use app_name instead of hardcoding Login.gov

tomas-nava · 2022-09-26T18:51:20Z

config/locales/user_mailer/es.yml

+          href="%{help_center_url}">visitar nuestro Centro de Ayuda</a> o
+          ponerse en contacto con la agencia a la que intenta acceder.
+        intro: Entendemos que estaba intentando verificar su identidad a través de
+          Login.gov, sin embargo, su identidad no pudo ser verificada en la


Suggested change

Login.gov, sin embargo, su identidad no pudo ser verificada en la

%{app_name}, sin embargo, su identidad no pudo ser verificada en la

We should always use app_name instead of hardcoding Login.gov

tomas-nava · 2022-09-26T18:51:50Z

config/locales/user_mailer/fr.yml

+          href="%{help_center_url}">consulter notre centre d’aide</a> ou
+          contacter l’agence à laquelle vous essayez d’accéder.
+        intro: Nous comprenons que vous avez tenté de vérifier votre identité par le
+          biais de Login.gov, mais votre identité n’a pas pu être vérifiée au


Suggested change

biais de Login.gov, mais votre identité n’a pas pu être vérifiée au

biais de %{app_name}, mais votre identité n’a pas pu être vérifiée au

We should always use app_name instead of hardcoding Login.gov

svalexander added 9 commits September 19, 2022 10:04

string translations added

0395b38

fraud email template

6143218

update string used in fraud erb file

74c374a

update strings so hyperlink works

0b152a0

add check to send alternate failed email

916fa57

add test for new email to proofing results job spec

b4990eb

add new failed email test to user mailer spec

92c2043

remove first_name from email as it's not available at this point of t…

34ba8c1

…he process

Improvements, GetUspsProofingResultsJob, add additonal failure email

416f77c

svalexander changed the title ~~Shannon/lg 6896 email failed fraud~~ LG-6896: Send 'fraud suspected' in-person proofing failed email Sep 22, 2022

changed hi to hello

c112622

tomas-nava reviewed Sep 22, 2022

View reviewed changes

app/jobs/get_usps_proofing_results_job.rb Outdated Show resolved Hide resolved

svalexander added 2 commits September 22, 2022 16:13

remove erroneous first_name from user mailer spec

30b6f85

change deliver now or later to deliver later

8992f9f

NavaTim reviewed Sep 22, 2022

View reviewed changes

app/jobs/get_usps_proofing_results_job.rb Outdated Show resolved Hide resolved

svalexander added 4 commits September 22, 2022 17:38

Merge branch 'main' of https://github.com/18F/identity-idp into shann…

8d3a69d

…on/lg-6896-email-failed-fraud

change fraudSuspected to boolean and switched back to deliver_now_or_…

8d0369e

…later

change back to deliver_later

b3173d0

lint changes

3183dfe

aduth approved these changes Sep 26, 2022

View reviewed changes

svalexander added 6 commits September 26, 2022 12:10

adding suggestions

4f04103

new line

9d24ad7

remove line

05c21ba

Improvement, User Mailer, send suspected fraud failure email

28ec50a

changelog:Improvement, GetUspsProofingResultsJob, send suspected frau…

238f674

…d failure email

changelog: Improvement, GetUspsProofingResultsJob, send suspected fra…

a004c26

…ud failure email

tomas-nava reviewed Sep 26, 2022

View reviewed changes

update login.gov to use const instead of str

6db2d13

NavaTim approved these changes Sep 26, 2022

View reviewed changes

svalexander merged commit 688a0d1 into main Sep 26, 2022

svalexander deleted the shannon/lg-6896-email-failed-fraud branch September 26, 2022 20:23

solipet mentioned this pull request Sep 26, 2022

Deploy RC 212 to Prod #7031

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LG-6896: Send 'fraud suspected' in-person proofing failed email#7013

LG-6896: Send 'fraud suspected' in-person proofing failed email#7013
svalexander merged 23 commits intomainfrom
shannon/lg-6896-email-failed-fraud

svalexander commented Sep 22, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

aduth left a comment

Uh oh!

aduth Sep 26, 2022

Uh oh!

aduth Sep 26, 2022

Uh oh!

tomas-nava left a comment

Uh oh!

tomas-nava Sep 26, 2022

Uh oh!

tomas-nava Sep 26, 2022

Uh oh!

tomas-nava Sep 26, 2022

Uh oh!

tomas-nava Sep 26, 2022

Uh oh!

tomas-nava Sep 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	if response['fraudSuspected'] == true
	if response['fraudSuspected']

	subject: t('user_mailer.in_person_failed_suspected_fraud.subject', app_name: APP_NAME),
	subject: t('user_mailer.in_person_failed_suspected_fraud.subject'),

	Login.gov, however your identity could not be verified at the
	%{app_name}, however your identity could not be verified at the

	Login.gov, sin embargo, su identidad no pudo ser verificada en la
	%{app_name}, sin embargo, su identidad no pudo ser verificada en la

	biais de Login.gov, mais votre identité n’a pas pu être vérifiée au
	biais de %{app_name}, mais votre identité n’a pas pu être vérifiée au

Conversation

svalexander commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduth left a comment

Choose a reason for hiding this comment

Uh oh!

aduth Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

aduth Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

tomas-nava left a comment

Choose a reason for hiding this comment

Uh oh!

tomas-nava Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

tomas-nava Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

tomas-nava Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

tomas-nava Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

tomas-nava Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

svalexander commented Sep 22, 2022 •

edited

Loading