Fix link in email when confirming new email address for existing account#7019
Merged
mitchellhenke merged 1 commit intomainfrom Sep 22, 2022
Merged
Conversation
…irming new email address for existing account
Comment on lines
38
to
+39
| <%= link_to add_email_confirmation_url(_request_id: @request_id, confirmation_token: @token, locale: @locale), | ||
| sign_up_create_email_confirmation_url( | ||
| add_email_confirmation_url( |
Contributor
There was a problem hiding this comment.
💡 what if we assigned @add_email_url in the mailer, and then re-used that variable here in the template instead of re-creating it 3 times, risking having different results? (I can also make a follow-up PR)
Contributor
Author
There was a problem hiding this comment.
Yep, I'm good with that
mitchellhenke
pushed a commit
that referenced
this pull request
Sep 22, 2022
…irming new email address for existing account (#7019)
zachmargolis
added a commit
that referenced
this pull request
Sep 22, 2022
- Follow-up to #7019 to prevent similar bugs in the future [skip changelog]
zachmargolis
added a commit
that referenced
this pull request
Sep 26, 2022
- Follow-up to #7019 to prevent similar bugs in the future [skip changelog]
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.