Deploy RC 210 to Production#6984
Merged
mitchellhenke merged 22 commits intostages/prodfrom Sep 19, 2022
Merged
Conversation
* Remove code for flag backup_code_reminder_redirect changelog: Internal, Authentication, Remove feature flag backup_code_reminder_redirect (LG-7490)
* LG-7418 Omit failure reason when not relevant changelog: Internal, Attempts API, Omit failure reason when not relevant * added specs
**Why**: It's noisy in development, and STDOUT is ignored in prod [skip changelog]
changelog: Internal, Logging, Log metadata about Attempts API
* Add delay between polling requests to USPS * Switch to ms. Move variable out of loop scope * changelog: Upcoming Features, In-person proofing, add a configurable delay between usps status checks * Convert ms to seconds * Use a better variable name * Better variable name * Better variable name again
* Update combined-invoice-supplement report to use sp_return_logs * Add manual retry + rollback **Why**: Sometimes these long-running queries get serialization errors, so let's retry them individually rather than throw away the whole report changelog: Internal, Reporting, Update billing reports to be more accurate
…nfig (#6965) * LG-6925: Move client_id field for USPS API from hardcoded value to config * [skip changelog]
-- What This commit updates that Procfile to have mailcatcher check for local https in development environments and to use the open local IP in such cases. Additionally, we provide better detail on how to customize your own `application.yml` config to enable local dev on https. You can copy and paste the values and replace your own IP. changelog: Internal, Local Development, config update and documentation
…6909) * increment failed capture event if we get the review warning screen * Add changelog changelog: Improvements, Native Camera, Use native camera after 2 failed submissions * define FailedCaptureAttemptContext * Updating FailedCaptureAtttempts context to track failed submissions -- What We need to track failed submissions in addition to failed captures, and trigger forceNativeCamera accordingly. The easiest way to accomplish this without touching the backend is to simply add this as a property to the failed capture context, then increment it on the review page. In a subsequent commit, we should explore not even incrementing this, but simply checking the upload remainingAttempts against the configured maximum value, and setting forceNativeCamera based on that. Updating tests accordingly. changelog: Improvements, Acuant Capture, updating ability to force native camera * adding max_submission_attempts_before_native_camera -- What This commit has two main changes: 1. We are renaming `max_attempts_before_native_camera` and its JS equivalent `maxAttemptsBeforeNativeCamera` to `max_capture_attempts_before_native_camera` etc. 2. We are adding a new configuration option called `max_submission_attempts_before_native_camera`, and linking submission attempt failure counting to check for exceeding this value when determining the `forceNativeCamera` boolean in the FailedCaptureContext. changelog: Improvements, Document Submission, adding force native camera option for failed submissions * Fixing lint errors changelog: Improvements, Document Capture, adding native camera option for failed submissions * Updating analytics function signature for forced native camera -- What With the new distinction between failed_capture_attempts and failed_submission_attempts -- and the corresponding way that these are logged from the frontend -- we need to update the new explicit analytics method signature on the Ruby side. changelog: Improvements, Document Capture, adding native camera capability to failed submission attempts * Update app/services/analytics_events.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Ensuring that isMobile is checked before forcing native camera -- What Previously, Acuant SDK failures were the only way to set forceNativeCamera. These _always_ occur in the context of a mobile device, due to how the SDK loads. However, we are now giving this option to people who fail to _submit_ more than twice, which can also occur on desktop. The upshot is that Chrome browsers were triggering a file picker twice in a row on desktop environments, because we were not explicitly checking to ensure that the current environment was mobile before calling forceUpload(). This has now been rectified. I have also updated the tests accordingly. changelog: Improvements, Document Capture, adding native camera option for failed submissions * Adjusting the logic in acuant-capture for forcing native camera changelog: Improvements, Document Capture, enabling native camera after failed submissions Co-authored-by: eric-gade <eric.gade@gsa.gov> Co-authored-by: Eric Gade <105373963+eric-gade@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* LG-7299 Add delivery preference to OTP sent events changelog: Internal, Attempts API, Track additional events
**Why**: Because it's unused. This behavior is enforced via the check_or_render_not_found defined at the top of the controller. changelog: Internal, Code Quality, Remove unreachable code
* Mock VA API for testing Why: Inherited proofing team needs a way to mock api calls to the va api for testing changelog: Internal, Inherited Proofing, Adding a mock VA API * Refactors to base mock around VA service Rather than around the VA API. * Add feature spec to make sure proofer works with our VA IP Form Co-authored-by: gangelo <web.gma@gmail.com>
* Document available changelog categories **Why**: So that the distinction between the available options is more clearly understood, and so that a developer doesn't need to sift through the implementation of the linter to understand which categories are available. * Add changelog changelog: Internal, Documentation, Document available changelog categories * Remove "Accessibility" as a changelog category #6977 (comment)
**Why**: Because the results email instructs the user to sign in through the associated service provider, and since it's expected to match the text link immediately following the button. This was intended to be implemented in LG-7076 (#6707). changelog: Upcoming Features, In-person proofing, Use partner homepage link for "Sign in" in results email notification
**Why**: As I user I want to know if it's ok for me to bring a physical copy or digital of my secondary ID if my current address is not the same as the one printed on my physical address. changelog: Upcoming Features, In-person Proofing, Add text clarifying acceptance of digital forms of proof of address
* Expand changelog documentation with more detail **Why**: For better clarity around the overall form of a changelog message, where it should exist, and details about subcategory and description of the message. changelog: Internal, Documentation, Document available changelog categories * Add example for subcategory https://github.com/18F/identity-idp/pull/6980/files#r973265287
* ipp changed to in_person * [skip changelog] * update another folder that was named ipp to in_person
**Why**: So that the Process List as displayed in email messages is consistent with the design system reference implementation. It's assumed this is a side-effect of the revisions in #6736, where an increase in default email line-height of 1.3 to 1.5 caused an offset of the appearance of the text of the list item number. Explicitly assigning the line-height ensures correct math. changelog: Bug Fixes, Email Templates, Improve appearance of Process List in email template
…ed_in_at (#6979) changelog: Internal, Performance, Limit selection of sign in events to 2 when fetching second_last_signed_in_at
…n text to be clearer to users (#6961) * changelog: Improvements, Consent Screen updates, Update Consent screen text to be clearer to users * changelog: Improvements, Authentication, Update sign in completed content page * change to sp * update spec * lg-6608: update lint * add spec to check config * add spec * update linting and spec * add check in completions controller * add translations * add new spec test
* add event to track show password toggle * add pathname to trackEvent * remove background analytics event * remove success from trackEvent * add base url check??? * remove console log, make sure to get path in window * remove authentication requirement and update test * add more context to show password event * add show password button clicked to analytics and log * nit: add space between events changelog: Internal, Analytics, Add analytics event for show password button * fix lint error * fix lint error again * Empty-Commit * try error fix again * try to fix lint error again * try again with linter try to make the linter happy * write test for click event
* initial flowstate test push * Add all UI for get started page and en.yml * lint fix * consent page changes * more changes to consent page and controller * inherit form InheritedProofingBaseStep * Fix lint/rubocop * Comment unused before filters * [skip changelog] empty commit * [skip changelog] empty commit * skip changelog * empty commit * add translation placeholders * Add translations for errors * fix duplicate keys * normalize yml * Remove cancel * remove unused locales keys * comment unused methods * delete unused methods * add interpolation placeholders for es and fr * remove unsed js * Pr comments * Get past i18n-tasks unused keys error * Specs for views and steps * remove debugging inspect * add locales for heading * more view specs * verify info placeholder specs * feature tests for agreement step * pr comments * remove comments * more pr comments on fixing specs Co-authored-by: Rakesh <rakesh@Amivero-39.local> Co-authored-by: Rakesh <rakesh@Amivero-39.attlocal.net> Co-authored-by: gangelo <web.gma@gmail.com>
mitchellhenke
requested review from
NavaTim,
aduth,
eric-gade,
jc-gsa,
jmhooper,
olatifflexion and
zachmargolis
Contributor
|
There's been a few more merges in the past couple hours than what's included here, do we want to pull those in? |
aduth
approved these changes
Sep 19, 2022
Contributor
Author
Whoops, yep, pulled them in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Bug Fixes
Internal
Upcoming Features