increment failed capture event if we get the review warning screen

[peggles2]

No description provided.

[aduth]

I'm noticing a strange behavior when testing this on desktop. After submitting twice with a failing result, I can choose to upload a new image, but as soon as I select an image, the prompt to select an image reappears, leading to a situation where I can't change the image.

pr-6909.mov

These changes are targeted at mobile, but the same component is also used on desktop.

I think what might be happening is that the call to forceUpload() in startCaptureOrTriggerUpload is redundant in this case, since on desktop the function would be triggered by the default file selection, so calling forceUpload only serves to show a second file selection prompt.

identity-idp/app/javascript/packages/document-capture/components/acuant-capture.tsx

Lines 415 to 422 in efcff15

	function startCaptureOrTriggerUpload(event: MouseEvent) {
	if (event.target === inputRef.current) {
	if (forceNativeCamera) {
	trackEvent('IdV: Native camera forced after failed attempts', {
	field: name,
	failed_attempts: failedCaptureAttempts,
	});
	return forceUpload();

[eric-gade]

Aha, yes, good catch there. Prior to this, it was only Acuant SDK failures that would meet the criteria (and therefore only in mobile environments). We need to now ensure that we are checking for mobile explicitly.

Oddly, I can reproduce this behavior in Chrome, but not FF

[aduth]

Checking mobile seems to be only indirectly related to the logic associated with starting Acuant capture. In fact, I hadn't realized that we're already evaluating whether to use Acuant on the lines immediately following this condition (shouldStartAcuantCapture), so the logic associated with forcing native camera in this condition seems a bit redundant. I think we should consider forceNativeCamera as part of that assignment and avoid the call to forceUpload altogether.

    if (event.target === inputRef.current) {
      const isAcuantCaptureCapable = hasCapture && !acuantFailureCookie;
      const isEnvironmentCapture = capture !== 'user';
      const shouldStartAcuantCapture =
        isAcuantCaptureCapable &&
        isEnvironmentCapture &&
        !isForceUploading.current &&
        !forceNativeCamera;
      const shouldStartSelfieCapture =
        isAcuantLoaded && capture === 'user' && !isForceUploading.current;

      if (isAcuantCaptureCapable && isEnvironmentCapture && forceNativeCamera) {
        trackEvent('IdV: Native camera forced after failed attempts', {
          field: name,
          failed_capture_attempts: failedCaptureAttempts,
          failed_submission_attempts: failedSubmissionAttempts,
        });
      }

      if (!allowUpload || shouldStartSelfieCapture || shouldStartAcuantCapture) {
        event.preventDefault();
      }

      // ...

[aduth]

LGTM 👍