Fix "Sign in" button link for IPP results email#6974
Merged
Conversation
**Why**: Because the results email instructs the user to sign in through the associated service provider, and since it's expected to match the text link immediately following the button. This was intended to be implemented in LG-7076 (#6707). changelog: Upcoming Features, In-person proofing, Use partner homepage link for "Sign in" in results email notification
NavaTim
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Because the results email instructs the user to sign in through the associated service provider, and since it's expected to match the text link immediately following the button. This was intended to be implemented in LG-7076 (#6707).
In the screenshot below, the revisions here change the "Sign in" button to link to the same place as the text following the button. In this example, linking to http://localhost:9292 (the partner homepage) instead of http://localhost:3000/verify (the IdV URL).