Limit selection of sign in events to 2 when fetching second_last_signed_in_at#6979
Merged
mitchellhenke merged 1 commit intomainfrom Sep 19, 2022
Merged
Limit selection of sign in events to 2 when fetching second_last_signed_in_at#6979mitchellhenke merged 1 commit intomainfrom
mitchellhenke merged 1 commit intomainfrom
Conversation
aduth
approved these changes
Sep 16, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
There's no direct test coverage for this method. Should we add some?
mdiarra3
approved these changes
Sep 16, 2022
mitchellhenke
force-pushed
the
mitchellhenke/limit-events-2fa
branch
from
b2b897d to
8eb0fce
Compare
Contributor
Author
Thanks for catching that, added a simpler baseline test for the intended functionality. |
…ed_in_at changelog: Internal, Performance, Limit selection of sign in events to 2 when fetching second_last_signed_in_at
mitchellhenke
force-pushed
the
mitchellhenke/limit-events-2fa
branch
from
8eb0fce to
4d43ca2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently selects all and only takes the second. This is a small change to only select up to 2