Merged
Conversation
**Why**: - Consistency between application and email typography - Avoid ad-hoc overrides in specific email templates (see included IPP template simplifications) - Reduce confusion on "lead" paragraph styling (TIL the first paragraph of an email will be 16.25px because it's a "lead" paragraph?) - Improve accessibility by using a recommended comfortable baseline size (see https://accessibility.digital.gov/visual-design/typography/) changelog: Improvements, Email, Align email content appearance with application typography
mitchellhenke
approved these changes
Aug 12, 2022
nickttng
approved these changes
Aug 12, 2022
anniehirshman-gsa
approved these changes
Aug 12, 2022
Contributor
anniehirshman-gsa
left a comment
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
Great thank you! 👍
I could see an argument for the content at the bottom of the email being smaller... but in that case, it would still be helpful to have the default font size larger. We can address that as it comes up in the future
aduth
added a commit
that referenced
this pull request
Sep 16, 2022
**Why**: So that the Process List as displayed in email messages is consistent with the design system reference implementation. It's assumed this is a side-effect of the revisions in #6736, where an increase in default email line-height of 1.3 to 1.5 caused an offset of the appearance of the text of the list item number. Explicitly assigning the line-height ensures correct math. changelog: Bug Fixes, Email Templates, Improve appearance of Process List in email template
aduth
added a commit
that referenced
this pull request
Sep 16, 2022
**Why**: So that the Process List as displayed in email messages is consistent with the design system reference implementation. It's assumed this is a side-effect of the revisions in #6736, where an increase in default email line-height of 1.3 to 1.5 caused an offset of the appearance of the text of the list item number. Explicitly assigning the line-height ensures correct math. changelog: Bug Fixes, Email Templates, Improve appearance of Process List in email template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Screenshots:
(This is just an example of one email template affected, but this adjustment will apply to all messages sent. I can make these changes available in my personal sandbox if that's an easier way to test real-world impact)