Lg 7463 va mock proofer

[holytoastr]

Provides a basic mock API call for environments where we cannot access the VA API staging environment

[gangelo]

@holytoastr open to whether or not we should include the new object the VA is returning, but my inclination is that we should include it :(

[jscodefix]

In my opinion, there is no reason to validate the auth_code (as being mocked-auth-code-for-testing); why do we care what the auth_code is, just accept anything and return the values. @rnagilla-gsa ... I'll defer to your opinion.

[gangelo]

In my opinion, there is no reason to validate the auth_code (as being mocked-auth-code-for-testing); why do we care what the auth_code is, just accept anything and return the values. @rnagilla-gsa ... I'll defer to your opinion.

Hi @jscodefix,

That is a good question.

Yes, I did think of just checking if blank?; we at least care about that since this proofer will get called if the Inherited Proofer FF is turned off, in which case the "real" codez should at least pass something; if this is not the case, it will at least eliminate that surprise.

Yes, so, the only time we should ever be calling this proofer is when the Inherited Proofer FF is turned off, in which case the only auth code we should ever be passing to the proofer is 'mocked-auth-code-for-testing' because we'd be using the sinatra app instead.

If the IP FF flag is turned on and we're using the sinatra app (locally or on int), we need to make sure the sinatra app is passing 'mocked-auth-code-for-testing' because we'd be calling the VA staging endpoint which only (currently) recognizes that auth code. I assume you're testing for this in the sinatra app, but there's nothing wrong with a little redundancy.

The only solid reason I can think of removing that guard (and just checking if blank?), is if the VA decides to provide additional mock auth codes that might (for example), force an error of some kind, return different mhv_data, etc. In this case, the sinatra app would provide multiple auth codes, and we'd have to remove/refactor that guard.

We can remove that guard, I just like the peace of mind knowing that the auth code can make its way from the sinatra app all the way to the proofer without surprises.

CC @rnagilla-gsa, @holytoastr