Add front end logging for "Show password" clicks#6946
Merged
Conversation
aduth
reviewed
Sep 13, 2022
app/javascript/packages/password-toggle/password-toggle-element.ts
Outdated
Show resolved
Hide resolved
jmdembe
force-pushed
the
LG-6143-show-password-analytics
branch
from
2560e97 to
864b38b
Compare
changelog: Internal, Analytics, Add analytics event for show password button
jmdembe
force-pushed
the
LG-6143-show-password-analytics
branch
from
864b38b to
87648eb
Compare
jmdembe
force-pushed
the
LG-6143-show-password-analytics
branch
from
88334c7 to
66f2f2f
Compare
try to make the linter happy
jmdembe
force-pushed
the
LG-6143-show-password-analytics
branch
from
66f2f2f to
28c81ec
Compare
jmdembe
force-pushed
the
LG-6143-show-password-analytics
branch
from
4166184 to
5eed47b
Compare
mdiarra3
approved these changes
Sep 16, 2022
aduth
reviewed
Sep 16, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I have a question at #6946 (comment)
aduth
reviewed
Sep 21, 2022
| 'IdV: download personal key' => :idv_personal_key_downloaded, | ||
| 'IdV: Native camera forced after failed attempts' => :idv_native_camera_forced, | ||
| 'Multi-Factor Authentication: download backup code' => :multi_factor_auth_backup_code_download, | ||
| 'Show Password Button Clicked' => :show_password_button_clicked, |
Contributor
There was a problem hiding this comment.
This mapping is not working as expected, and the events are still being logged with the "Frontend:" prefix. I think it has to do with the difference in case, "Show Password Button Clicked" vs. "Show Password button clicked".
Suggested change
| 'Show Password Button Clicked' => :show_password_button_clicked, | |
| 'Show Password button clicked' => :show_password_button_clicked, |
This was referenced Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds front-end logging to track if the "Show password" button has been clicked and the location of the button.
Why? So that, as a team, we can get insight on where that button is being used, and to inform future development of that feature