Skip to content

Remove unused method render_404_if_disabled#6973

Merged
aduth merged 1 commit intomainfrom
aduth-rm-unused-404-if-disabled
Sep 16, 2022
Merged

Remove unused method render_404_if_disabled#6973
aduth merged 1 commit intomainfrom
aduth-rm-unused-404-if-disabled

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Sep 16, 2022

Why: Because it's unused. This behavior is enforced via the check_or_render_not_found defined at the top of the controller:

check_or_render_not_found -> { InPersonConfig.enabled_for_issuer?(current_sp&.issuer) }

**Why**: Because it's unused. This behavior is enforced via the check_or_render_not_found defined at the top of the controller.

changelog: Internal, Code Quality, Remove unreachable code
@aduth aduth requested review from a team and svalexander September 16, 2022 13:44
Copy link
Contributor

@sheldon-b sheldon-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit 09e4112 into main Sep 16, 2022
@aduth aduth deleted the aduth-rm-unused-404-if-disabled branch September 16, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants