Skip to content

LG-6925: Move client_id field for USPS API from hardcoded value to config#6965

Merged
NavaTim merged 2 commits intomainfrom
tbradley/lg-6925-move-usps-clientid-to-config
Sep 15, 2022
Merged

LG-6925: Move client_id field for USPS API from hardcoded value to config#6965
NavaTim merged 2 commits intomainfrom
tbradley/lg-6925-move-usps-clientid-to-config

Conversation

@NavaTim
Copy link
Contributor

@NavaTim NavaTim commented Sep 15, 2022

This pull request sources the client_id value from the config instead of hardcoding it. See LG-6925 for more details.

I plan to have the config deployed with the client_id to each environment before or during the deployment of this code (and will coordinate w/ others before merging to make sure that happens).

@NavaTim NavaTim requested review from a team and sheldon-b September 15, 2022 03:19
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@svalexander
Copy link
Contributor

svalexander commented Sep 15, 2022

I was able to find a bit more on where client_id came from (one of the questions mentioned in the ticket). I reached out to Zach M. to ask about it, he shared an email thread from around the time client_id was originally introduced - the id value was given to us from USPS in order for Login to be authenticated as a user for the USPS apis. I'll add a comment in the ticket with that info so we have a place to refer back to if the question pops up again.

Edited to include:
I see you have a comment already in the jira ticket with the historical information on where client_id came from, so I won't add to it afterall.

@NavaTim NavaTim merged commit cf2bc30 into main Sep 15, 2022
@NavaTim NavaTim deleted the tbradley/lg-6925-move-usps-clientid-to-config branch September 15, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants