Conversation
Procfile
Outdated
There was a problem hiding this comment.
now this comment is out of date, we can remove
| # To test locally with HTTPS, swap the commented | |
| # mailcatcher command below with the currently | |
| # active version. See the README for more | |
| # information on local development |
eric-gade
force-pushed
the
eric-https-localdev-config
branch
from
ac5485d to
f1d596c
Compare
config/application.yml
Outdated
There was a problem hiding this comment.
should we point to a specific part of the README, like "Testing on a mobile device or in a virtual machine", or make those instructions match there?
I guess what I'm really asking is, how can we make this comment shorter and potentially reduce duplication if possible?
config/application.yml
Outdated
There was a problem hiding this comment.
I'd like to understand this a bit more:
- How is this file even being included, if it's explicitly gitignore'd
- When I checked out this branch, it blew away my local
application.ymlwhich is quite an inconvenience. Is that going to happen to everyone when it's merged?
There was a problem hiding this comment.
Also, when I make changes to this file locally, they're marked for commit, which I don't think we'd want.
There was a problem hiding this comment.
Should we add these comments into application.yml.default instead?
There was a problem hiding this comment.
How about we roll back all the application.yml changes, and simply update the README so that the template values can be copied and pasted in the correct place? I definitely don't want to be messing up people's workflows and this might be the best compromise
-- What This commit updates that Procfile to have mailcatcher check for local https in development environments and to use the open local IP in such cases. Additionally, we provide better detail on how to customize your own `application.yml` config to enable local dev on https. You can copy and paste the values and replace your own IP. changelog: Internal, Local Development, config update and documentation
eric-gade
force-pushed
the
eric-https-localdev-config
branch
from
f1d596c to
50d7d19
Compare
3 participants
What
This PR updates the
Procfileandapplication.ymlfiles in the repository with commented-out options that can be uncommented and modified for running the application in https locally.Comments also provide context for how to run https locally and how to use the given options.
I have found that having to go back and forth to several docs to find the appropriate keys and values to use is a bit annoying, and I think this might be a little easier for new people coming on also. LMK what you think.