Skip to content

LG-7362: Add copy for digital forms of IPP proof of address#6975

Merged
aduth merged 1 commit intomainfrom
aduth-lg-7362-digital-copy
Sep 16, 2022
Merged

LG-7362: Add copy for digital forms of IPP proof of address#6975
aduth merged 1 commit intomainfrom
aduth-lg-7362-digital-copy

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Sep 16, 2022

Why: As I user I want to know if it's ok for me to bring a physical copy or digital of my secondary ID if my current address is not the same as the one printed on my physical address.

Screenshots:

Screen Before After
Prepare lg-7362-prepare-before lg-7362-prepare-after
Barcode lg-7362-barcode-before lg-7362-barcode-after
Email lg-7362-email-before lg-7362-email-after

**Why**: As I user I want to know if it's ok for me to bring a physical copy or digital of my secondary ID if my current address is not the same as the one printed on my physical address.

changelog: Upcoming Features, In-person Proofing, Add text clarifying acceptance of digital forms of proof of address
Copy link
Contributor

@sheldon-b sheldon-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

created_at: Time.zone.now - 2.hours,
status_updated_at: Time.zone.now - 1.hour,
current_address_matches_id: true,
current_address_matches_id: params['current_address_matches_id'] == 'true',
Copy link
Contributor Author

@aduth aduth Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to mention this in the original pull request. Previously, the preview would omit the "Bring proof of address" content, consistent with the expected behavior when the current address matches the ID. This flips the default, but also allows for it to be hidden by adding a query parameter ?current_address_matches_id=true.

Copy link

@kellular kellular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aduth aduth merged commit e88139b into main Sep 16, 2022
@aduth aduth deleted the aduth-lg-7362-digital-copy branch September 16, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants