Merged
Conversation
Resolves LG-5273 This was causing our config seeders to fail due to an edge case where an integration was moved to a different account.
* fix header size on account reset request page * Update app/views/account_reset/request/show.html.erb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Add `all_emails` prop to OIDC userinfo **Why**: So that if SPs have users with multiple email addresses, they can access those email addresses
* Add /api/country-support for SMS/voice support * Fix CORS specs, anchor domains Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* LG-5040: refactor text field * add inline js * validation html * LG-5040: refactor text field * LG-5040: add inline validation * LG-5040: validation yaml fixes * LG-5040: updated inputs for inline-validation * LG-5040: leverage css more * LG-5040: fix linting issue * LG-5040: lint fixes * LG-5040: update spec to make sure its properly setting aria invalid propelry * LG-5040: clean up styling, remove error-state css class * LG-5040: lint fix * LG-5040: add validation to send link and verify account * LG-5040: bad spacing * LG-5040: update styling * LG-5040: add padding * LG-5157: address invalidation inline * LG-5157: address line validation * LG-5157: add new address inline validation * LG-5157: fix up html * LG-5157: fix linting issue * LG-5157: update spec file * update spacing
- Also adds a Rubocop linter to help keep us consistent * Add feature flag * Move deliver_now_or_later to ActionMailer::MessageDelivery - because it's called on the result of methods on ActionMailer::Base subclasses, not on the mailers themselves
* add failing spec * ask for password if profile is available but not decrypted * fix flaky device spec * fix specs * split decryption check into method
- Fail open because we can't tell what a number is
aduth
approved these changes
Oct 26, 2021
* simple version of continuing to SP after recovering with personal key * Update app/views/accounts/_personal_key.html.erb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * fix specs * fix erblint * add spec * move sp continue into own partial * add translations Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
approved these changes
Oct 27, 2021
* smoke testing test * Update spec/support/monitor/monitor_email_helper.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * lint * fix * remove old environment variable usage * remove gmail * re-enable smoke test alerts Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> (cherry picked from commit 9f8aa76)
- Also remove now-outdated comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.