Conversation
mitchellhenke
force-pushed
the
mitchellhenke/where-theres-smoke-tests
branch
2 times, most recently
from
83ae930 to
20f1bd4
Compare
There was a problem hiding this comment.
😭 😭 😭
Is it possible to generate one 30 seconds in the future and hope that our site allows some clock skew?
There was a problem hiding this comment.
Or maybe should we just do backup codes and save the backup codes in memory? This seems like a very long time to wait
There was a problem hiding this comment.
It's a bummer, but I don't super mind since smoke tests don't generally block PRs, and different environments can now run simultaneously
There was a problem hiding this comment.
That's true! But if we ever have to test these manually to verify, 30 seconds feels like an eternity
There was a problem hiding this comment.
I'm open to switching to backup codes in this PR, but my feeling is to get something out now so smoke tests can start again
There was a problem hiding this comment.
Makes sense, I agree, probably better to ship something sooner
mitchellhenke
force-pushed
the
mitchellhenke/where-theres-smoke-tests
branch
4 times, most recently
from
1bbaeee to
5a0fd18
Compare
.circleci/config.yml
Outdated
There was a problem hiding this comment.
just leaving a note to make sure that we undo this before mergin
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
force-pushed
the
mitchellhenke/where-theres-smoke-tests
branch
2 times, most recently
from
967026d to
4332b7e
Compare
mitchellhenke
force-pushed
the
mitchellhenke/where-theres-smoke-tests
branch
from
4332b7e to
90436a5
Compare
* smoke testing test * Update spec/support/monitor/monitor_email_helper.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * lint * fix * remove old environment variable usage * remove gmail * re-enable smoke test alerts Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> (cherry picked from commit 9f8aa76)
2 participants
No description provided.