Increase report timeout, mark as long running#5544
Merged
zachmargolis merged 1 commit intomainfrom Oct 26, 2021
Merged
Conversation
zachmargolis
commented
Oct 25, 2021
| recurring_jobs_disabled_names: "[]" | ||
| redis_throttle_url: redis://redis.login.gov.internal:6379/1 | ||
| redis_url: redis://redis.login.gov.internal:6379 | ||
| report_timeout: 1_000_000 |
Contributor
Author
There was a problem hiding this comment.
I was suprised to learn that this is valid YAML:
require 'yaml'
YAML.load <<-STR
some_key: 1_000_000
STR
# => {"some_key"=>1000000}
Contributor
There was a problem hiding this comment.
also valid Ruby 🙂
irb(main):001:0> 1_000_000
=> 1000000
Contributor
Author
There was a problem hiding this comment.
yes! and valid Java these days too I just didn't realize YAML was also in the underscores club
mitchellhenke
approved these changes
Oct 26, 2021
| module Reports | ||
| class BaseReport < ApplicationJob | ||
| queue_as :low | ||
| queue_as :long_running |
Contributor
There was a problem hiding this comment.
This is great 👍🏼 👍🏼 👍🏼 👍🏼 👍🏼
| recurring_jobs_disabled_names: "[]" | ||
| redis_throttle_url: redis://redis.login.gov.internal:6379/1 | ||
| redis_url: redis://redis.login.gov.internal:6379 | ||
| report_timeout: 1_000_000 |
Contributor
There was a problem hiding this comment.
also valid Ruby 🙂
irb(main):001:0> 1_000_000
=> 1000000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to re-run the
Reports::AgencyInvoiceIaaSupplementReportreport (since it has been failing out), and this was the config that I needed to get it there. A few queries took close to 100,000ms, but the when I set the timeout to 100k, queries still got canclledA more ideal fix would obviously be to optimize the underlying queries, but I think this is acceptable in the meantime:
Also updates the report base class to be the
long_runningqueue, because that means we won't alert on long running jobs for it... because they are expected to take a long time