Idea: JSON API to serve current SMS/voice support#5523
Merged
zachmargolis merged 6 commits intomainfrom Oct 20, 2021
Merged
Conversation
zachmargolis
commented
Oct 19, 2021
| @@ -0,0 +1,5 @@ | |||
| class CountrySupportController < ApplicationController | |||
| def index | |||
| render json: { countries: PhoneNumberCapabilities::INTERNATIONAL_CODES } | |||
Contributor
Author
There was a problem hiding this comment.
as a TODO if we do LG-5223 we need to make sure to update this part as well
4 tasks
zachmargolis
force-pushed
the
margolis-supported-countries-json
branch
from
258d9b8 to
89cbbee
Compare
Contributor
Author
|
Got some positive feedback so I think this is ready for review |
aduth
approved these changes
Oct 20, 2021
config/application.rb
Outdated
Comment on lines
+112
to
+113
| %r{https://www.login.gov}, | ||
| %r{https://login.gov}, |
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: GSA-TTS/identity-site#707