Fix 500 when SAML authenticating at IAL2 after password reset#5531
Merged
mitchellhenke merged 5 commits intomainfrom Oct 22, 2021
Merged
Fix 500 when SAML authenticating at IAL2 after password reset#5531mitchellhenke merged 5 commits intomainfrom
mitchellhenke merged 5 commits intomainfrom
Conversation
mitchellhenke
commented
Oct 22, 2021
spec/models/device_spec.rb
Outdated
Contributor
Author
There was a problem hiding this comment.
this is completely unrelated, but it randomly failed while working on this so I tried to make it more resilient
solipet
approved these changes
Oct 22, 2021
Contributor
solipet
left a comment
There was a problem hiding this comment.
Looks good, one optional comment.
Contributor
There was a problem hiding this comment.
Could move this condition to a new method identity_needs_decryption? since it's used in two places and would match the other checks more nicely.
7f589ae to
69d0933
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Less common, but possible path to get a 500 is (NR link):
This fix is similar to what we do in OIDC when facing the same circumstances:
identity-idp/app/controllers/openid_connect/authorization_controller.rb
Lines 119 to 122 in 23929e1