Merged
Conversation
Contributor
|
Is the goal to merge this separately? Should we change the base of this PR to the other branch so we can see just the incremental diff? https://github.com/18F/identity-idp/compare/md-lg-5040-refactor-text-field..md-lg-5157-address-inline-validation |
…into md-lg-5157-address-inline-validation
mdiarra3
force-pushed
the
md-lg-5157-address-inline-validation
branch
from
13c0a1e to
9900074
Compare
…into md-lg-5157-address-inline-validation
jmdembe
reviewed
Oct 19, 2021
jmdembe
reviewed
Oct 19, 2021
jmdembe
reviewed
Oct 19, 2021
aduth
approved these changes
Oct 20, 2021
jmdembe
approved these changes
Oct 20, 2021
aduth
reviewed
Oct 20, 2021
zachmargolis
approved these changes
Oct 21, 2021
Comment on lines
+8
to
+9
| <%= f.input :address1, label: t('idv.form.address1'), wrapper: false, | ||
| required: true, input_html: { aria: { invalid: false } }, maxlength: 255 %> |
Contributor
There was a problem hiding this comment.
supernit, the spacing here is a little off:
Suggested change
| <%= f.input :address1, label: t('idv.form.address1'), wrapper: false, | |
| required: true, input_html: { aria: { invalid: false } }, maxlength: 255 %> | |
| <%= f.input :address1, label: t('idv.form.address1'), wrapper: false, | |
| required: true, input_html: { aria: { invalid: false } }, maxlength: 255 %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works off of #5468. This PR updates the address page for IAL2 flow to support inline-validation instead of tooltips. Needs prior PR merged first.