Send cache headers in /api/country-support#5532
Merged
zachmargolis merged 3 commits intomainfrom Oct 22, 2021
Merged
Conversation
zachmargolis
requested review from
aduth,
jmhooper,
mitchellhenke and
stevegsa
zachmargolis
commented
Oct 21, 2021
| skip_before_action :disable_caching | ||
|
|
||
| def index | ||
| expires_in 15.minutes, public: true |
Contributor
Author
There was a problem hiding this comment.
my thinking was that a deploy takes us ~15 minutes, so that's the fastest we could change the configs
and the headers are really just a suggestion anyways, not like we have a CDN in front of this endpoint
aduth
approved these changes
Oct 22, 2021
| @@ -1,5 +1,11 @@ | |||
| class CountrySupportController < ApplicationController | |||
| prepend_before_action :skip_session_load | |||
| prepend_before_action :skip_session_expiration | |||
mitchellhenke
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick follow-up to add caching headers, so that if people repeatedly refresh GSA-TTS/identity-site#707, at least their browser will hopefully cache for a little bit