Skip to content

Remove personal key section from account reset template#5522

Merged
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/remove-personal-key-from-account-reset
Oct 20, 2021
Merged

Remove personal key section from account reset template#5522
mitchellhenke merged 1 commit intomainfrom
mitchellhenke/remove-personal-key-from-account-reset

Conversation

@mitchellhenke
Copy link
Contributor

@mitchellhenke mitchellhenke commented Oct 19, 2021

We don't allow using the personal key as a second factor any longer, so we shouldn't include content about it in this template as it is confusing for people.

Screenshot of current template before these changes:

image

After:

image

@zachmargolis
Copy link
Contributor

For some reason I thought we have some legacy accounts that do still allow this?

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but 🤷 on if we allow these to be used, I think this is okay? worst case we can always revert

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these translations now unused? if so should we delete?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, the i18n specs caught it

@mitchellhenke mitchellhenke force-pushed the mitchellhenke/remove-personal-key-from-account-reset branch from 1248282 to bb2bf92 Compare October 19, 2021 22:02
@mitchellhenke mitchellhenke requested a review from solipet October 19, 2021 22:04
@mitchellhenke
Copy link
Contributor Author

LGTM, but 🤷 on if we allow these to be used, I think this is okay? worst case we can always revert

I don't think we do. I tried myself with a verified account and don't see the option to use a personal key as 2FA. @solipet authored #4556, so I've added him as a reviewer 🙂

@solipet
Copy link
Contributor

solipet commented Oct 20, 2021

LGTM, but 🤷 on if we allow these to be used, I think this is okay? worst case we can always revert

I don't think we do. I tried myself with a verified account and don't see the option to use a personal key as 2FA. @solipet authored #4556, so I've added him as a reviewer 🙂

To my knowledge, the personal key is only used now to reactivate your verified profile after a password change. I don't know how you get to the original page shown in the description... 😕

Copy link
Contributor

@anniehirshman-gsa anniehirshman-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitchellhenke could you share an "after" screenshot of these changes when you get a chance? Want to make sure the content that isn't deleted still makes sense. Thanks!

@mitchellhenke
Copy link
Contributor Author

mitchellhenke commented Oct 20, 2021

@mitchellhenke could you share an "after" screenshot of these changes when you get a chance? Want to make sure the content that isn't deleted still makes sense. Thanks!

@anniehirshman-gsa For context, the removed content was only shown to users with a proofed identity, so the new version is what unproofed users saw. Now all users will see:

image

@anniehirshman-gsa
Copy link
Contributor

LGTM for this particular issue, thanks for adding that context!

@mitchellhenke mitchellhenke merged commit 9418442 into main Oct 20, 2021
@mitchellhenke mitchellhenke deleted the mitchellhenke/remove-personal-key-from-account-reset branch October 20, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants