Allow overriding SMS/voice support via feature flag (LG-5223)#5537
Merged
zachmargolis merged 1 commit intomainfrom Oct 25, 2021
Merged
Allow overriding SMS/voice support via feature flag (LG-5223)#5537zachmargolis merged 1 commit intomainfrom
zachmargolis merged 1 commit intomainfrom
Conversation
zachmargolis
requested review from
jmhooper,
mitchellhenke,
pauldoomgov and
stevegsa
zachmargolis
commented
Oct 22, 2021
Comment on lines
+2
to
+8
| def self.load_config | ||
| YAML.load_file( | ||
| Rails.root.join('config', 'country_dialing_codes.yml'), | ||
| ).deep_merge(IdentityConfig.store.country_phone_number_overrides) | ||
| end | ||
|
|
||
| INTERNATIONAL_CODES = load_config.freeze |
Contributor
Author
There was a problem hiding this comment.
Since it takes an app restart to change feature flags, and this value is read often (meaning changing constant accesses to a method read seems expensive), it seemed easy enough to me to keep it a constant
mitchellhenke
approved these changes
Oct 25, 2021
Contributor
mitchellhenke
left a comment
mitchellhenke
left a comment
There was a problem hiding this comment.
Do you think at some point we'll probably want to move all overrides into this?
Contributor
Author
I don't have a good sense, part of me think its nice to have the YAML in source code for most overrides, and this config would be for the quick emergency scenarios? The contents of the override file are big and it seems easy to make invalid JSON formatting with something that big? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we had this a few weeks ago, #5487 would not have needed a deploy + patch, we could have set a config like this: