Add link to continue to SP after recovering with personal key#5541
Add link to continue to SP after recovering with personal key#5541mitchellhenke merged 7 commits intomainfrom
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/ial2-personal-key-sp-continue
branch
from
9a97c88 to
20e42bf
Compare
mitchellhenke
force-pushed
the
mitchellhenke/ial2-personal-key-sp-continue
branch
from
20e42bf to
55903e2
Compare
There was a problem hiding this comment.
Technically out of scope and fine to defer, but how would you feel about cleaning up this file and eliminating it as an exception in .erb-lint.yml?
Line 17 in 41e1fa8
There was a problem hiding this comment.
I'm definitely good with doing that!
mitchellhenke
force-pushed
the
mitchellhenke/ial2-personal-key-sp-continue
branch
from
e9b5aab to
4765530
Compare
|
@aduth @zachmargolis got some feedback from UX and decided to move the "Continue" into its own box, which led to some weird changes with alert box margins. The main issue is the personal key alert box will disappear on refresh, and we wanted to preserve the ability to continue even if someone refreshes, changes password, etc. |
There was a problem hiding this comment.
Nice consolidation of this margin class 👏
app/views/accounts/show.html.erb
Outdated
There was a problem hiding this comment.
I haven't tested locally yet, but... is there a file missing here for _service_provider_continue.html.erb ?
mitchellhenke
force-pushed
the
mitchellhenke/ial2-personal-key-sp-continue
branch
from
e13cba6 to
5f968d5
Compare
app/view_models/account_show.rb
Outdated
There was a problem hiding this comment.
Could benefit from some spec coverage.
There was a problem hiding this comment.
I am not sure of a good way to test this. My hope is tests of the inner functions and content is sufficient to test indirectly since it won't show any of them if this function is broken. It did catch that I hadn't captured show_gpo_partial in the initial version 😬
mitchellhenke
force-pushed
the
mitchellhenke/ial2-personal-key-sp-continue
branch
from
d8f2a69 to
8723de0
Compare
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
force-pushed
the
mitchellhenke/ial2-personal-key-sp-continue
branch
from
8723de0 to
e030ef3
Compare
* simple version of continuing to SP after recovering with personal key * Update app/views/accounts/_personal_key.html.erb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * fix specs * fix erblint * add spec * move sp continue into own partial * add translations Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
3 participants
If you re-activate your profile with your personal key during an IAL2 authentication, you'll get your new personal key with no way to continue on to the service provider you are trying to reach.
Screenshot: