Deploy RC 401 to Production#11002
Merged
zachmargolis merged 18 commits intostages/prodfrom Jul 30, 2024
Merged
Conversation
* Failed doc auth result offers IPP offramp changelog: User-Facing Improvements, Doc Auth, Failed doc auth offers IPP offramp * remove showAlternativeProofingOptions since we offer IPP offramp for failed doc_auth we do not need this check anymore
…lag (#10977) The `no_verify_by_mail_for_biometric_comparison_enabled` was used to control whether the GPO option was available for users performing a biometric comparison. We have enabled the feature flag in production and will be moving forward with this feature. This commit retires the feature flag. [skip changelog]
* normalize-yaml: Add option to ignore keys in sorting * Sort keys in application.yml.default changelog: Internal, Code Quality, Sort keys in application.yml.default * Clarify ignore key sort option in README * Add spec for ignoreKeySort * Improve formatting for original and expected output Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Fix comment annotation arrangement --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…10984) changelog: Internal, In-person proofing, Set the sponsor_id field on in-person enrollments when they are created during the IPP usps location controller update request.
* Stub proofed user for PIV IdV sign-in spec changelog: Internal, Automated Testing, Improve performance of PIV IdV sign-in spec * Update spec references to OIDC Continue button
changelog: Internal, In-person proofing, Add enhanced_ipp property to the event properties of the "GetUspsProofingResultsJob: Enrollment status updated" analytic event.
* Use aria-hidden for decorative SVG images changelog: Bug Fixes, Accessibility, Use aria-hidden for decorative SVG images * Fix error on missing key method * Use positive check for selecting non-aria-hidden img Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Add explainer to accessibility matcher * Update accessibility matcher name to match new behavior --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
changelog: Internal, Automated Testing, Fix flakey IAA Agreements spec
* Use ActiveModel validations for components changelog: Internal, Components, Use ActiveModel validations for components * Avoid unnecessary predicate method for loop
changelog: Upcoming Features, IdV with Biometric Comparison, Adding acr_values --------- Co-authored-by: Lauren George <lauren.george@gsa.gov>
* changelog: Upcoming Features, Authentication, Recaptcha Sign in * fix spec * add test to ensure user redirected to security check failed * add additional languges and page * address comments * lint fix * address comments * use c * fix failed * sign in security check controller spec added * change spec name * use back instead of cancel * update security check failed spec
…onments (#10988) * restore rake task to backfill sponsor_id column in in_person_enrollments table * Changelog: Upcoming Features, In-person proofing, backfill sponsor id again * update in_person_enrollments factory and get tests passing * do clean up
* changelog: Upcoming Features, Authentication, let users who's passwords are compromised to change their password * add password compromised spec and edit objects * sign in spec updated * change to use user_password_params * address comments * change up to use password controller * password compromised updates * fix lint and use global variable * update edit spec and global variable * fix the sign in spec * fix form spec * address comments, update test to better redirect * remove former check * make sure invalid password method is correct * Update to make aria described conditional * update specs and use hash format for attributes instead of positional arguments * fix reset password form spec * remove conditional for password strength description
changelog: Internal, Source code, Add and fix predicate naming lint * Add back prefix for has_gov_or_mil_email? * Allow has_ prefix for predicate names Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * Clean up other request method name * Remove unused delegator on TwoFactorOptionsPresenter - Old method name: user_has_gov_or_mil_email? * Bring back a has_ --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
changelog: Internal, Maintenance, Remove unused methods
* changelog: Internal, CI, Change DNS zone for review apps to reviewapps
jmhooper
approved these changes
Jul 30, 2024
zachmargolis
requested review from
aduth,
eileen-nava,
gina-yamada,
jmhooper,
lmgeorge,
mdiarra3,
mitchellhenke,
shanechesnutt-ft,
stephencshelton and
theabrad
Sgtpluck
approved these changes
Jul 30, 2024
solipet
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features