Skip to content

LG-13715 Add enhanced_ipp to enrollment updated event#10962

Merged
shanechesnutt-ft merged 1 commit intomainfrom
sc/LG-13715-add-eipp-prop-to-enrollment-status-updated-event
Jul 25, 2024
Merged

LG-13715 Add enhanced_ipp to enrollment updated event#10962
shanechesnutt-ft merged 1 commit intomainfrom
sc/LG-13715-add-eipp-prop-to-enrollment-status-updated-event

Conversation

@shanechesnutt-ft
Copy link
Contributor

@shanechesnutt-ft shanechesnutt-ft commented Jul 18, 2024

🎫 Ticket

Link to the relevant ticket:
LG-13715

🛠 Summary of changes

  • Added enhanced_ipp to the properties.event_properties of the GetUspsProofingResultsJob: Enrollment status updated event.

📜 Testing Plan

Scenario:

EIPP -> USPS Proofing Passed -> Passed with unsupported Secondary ID - Logged

  • Login through the oidc sinatra application selecting the Enhanced In-person Proofing level of service.
  • Use an exisiting account or create an account
  • Follow the flow for creating an enrollment.
  • Once on the Verify view (/verify/in_person/ready_to_verify), open a new terminal and run: rails c
  • Grab the enrollment: e = InPersonEnrollment.last
  • Mock a passed response: json = JSON.parse(UspsInPersonProofing::Mock::Fixtures.request_passed_proofing_secondary_id_type_results_response)
  • Create a new job instance: job = GetUspsProofingResultsJob.new
  • Set the enrollment_outcomes class variable job.instance_variable_set('@enrollment_outcomes', { enrollments_passed: 0, enrollments_failed: 0 })
  • Send it: job.send(:process_enrollment_response, e, res)
  • Check the logs for "GetUspsProofingResultsJob: Enrollment status updated" event with property.event_properties.enhanced_ipp = true

EIPP -> USPS Proofing Passed -> Passed with Primary ID check - Logged

  • Login through the oidc sinatra application selecting the Enhanced In-person Proofing level of service.
  • Use an exisiting account or create an account
  • Follow the flow for creating an enrollment.
  • Once on the Verify view (/verify/in_person/ready_to_verify), open a new terminal and run: rails c
  • Grab the enrollment: e = InPersonEnrollment.last
  • Mock a passed response: json = JSON.parse(UspsInPersonProofing::Mock::Fixtures.request_passed_proofing_results_response)
  • Create a new job instance: job = GetUspsProofingResultsJob.new
  • Set the enrollment_outcomes class variable job.instance_variable_set('@enrollment_outcomes', { enrollments_passed: 0, enrollments_failed: 0 })
  • Send it: job.send(:process_enrollment_response, e, res)
  • Check the logs for "GetUspsProofingResultsJob: Enrollment status updated" event with property.event_properties.enhanced_ipp = true

ID IPP -> USPS Proofing Passed -> Passed with unsupported secondary ID - Logged

  • Login through the oidc sinatra application selecting the Biometrics level of service.
  • Use an exisiting account or create an account
  • Follow the flow for creating an enrollment.
  • Once on the Verify view (/verify/in_person/ready_to_verify), open a new terminal and run: rails c
  • Grab the enrollment: e = InPersonEnrollment.last
  • Mock a passed response: json = JSON.parse(UspsInPersonProofing::Mock::Fixtures.request_passed_proofing_secondary_id_type_results_response)
  • Create a new job instance: job = GetUspsProofingResultsJob.new
  • Set the enrollment_outcomes class variable job.instance_variable_set('@enrollment_outcomes', { enrollments_passed: 0, enrollments_failed: 0 })
  • Send it: job.send(:process_enrollment_response, e, res)
  • Check the logs for "GetUspsProofingResultsJob: Enrollment status updated" event with property.event_properties.enhanced_ipp = false

ID IPP -> USPS Proofing Passed -> Passed with Primary ID check - Logged

  • Login through the oidc sinatra application selecting the Biometrics level of service.
  • Use an exisiting account or create an account
  • Follow the flow for creating an enrollment.
  • Once on the Verify view (/verify/in_person/ready_to_verify), open a new terminal and run: rails c
  • Grab the enrollment: e = InPersonEnrollment.last
  • Mock a passed response: json = JSON.parse(UspsInPersonProofing::Mock::Fixtures.request_passed_proofing_results_response)
  • Create a new job instance: job = GetUspsProofingResultsJob.new
  • Set the enrollment_outcomes class variable job.instance_variable_set('@enrollment_outcomes', { enrollments_passed: 0, enrollments_failed: 0 })
  • Send it: job.send(:process_enrollment_response, e, res)
  • Check the logs for "GetUspsProofingResultsJob: Enrollment status updated" event with property.event_properties.enhanced_ipp = false

@shanechesnutt-ft shanechesnutt-ft force-pushed the sc/LG-13715-add-eipp-prop-to-enrollment-status-updated-event branch from 97934c7 to d0a881c Compare July 19, 2024 13:28
@shanechesnutt-ft shanechesnutt-ft marked this pull request as ready for review July 19, 2024 21:05
@shanechesnutt-ft shanechesnutt-ft force-pushed the sc/LG-13715-add-eipp-prop-to-enrollment-status-updated-event branch 3 times, most recently from 00a6998 to 4e4431e Compare July 22, 2024 17:09
Copy link
Contributor

@WilliamBirdsall WilliamBirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed testing scenarios successfully. LGTM

@shanechesnutt-ft shanechesnutt-ft force-pushed the sc/LG-13715-add-eipp-prop-to-enrollment-status-updated-event branch 2 times, most recently from fa806cf to 7cb956d Compare July 25, 2024 13:27
@shanechesnutt-ft shanechesnutt-ft force-pushed the sc/LG-13715-add-eipp-prop-to-enrollment-status-updated-event branch from 7cb956d to b26dce6 Compare July 25, 2024 17:46
Copy link
Contributor

@WilliamBirdsall WilliamBirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually approved this time :)

@shanechesnutt-ft shanechesnutt-ft force-pushed the sc/LG-13715-add-eipp-prop-to-enrollment-status-updated-event branch from b26dce6 to c29744d Compare July 25, 2024 18:59
@jennyverdeyen jennyverdeyen self-requested a review July 25, 2024 19:38
Copy link
Contributor

@jennyverdeyen jennyverdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walked through the testing plan, logs looks great! Reviewed the code, everything looks good to me! Nice work!

changelog: Internal, In-person proofing, Add enhanced_ipp property to
the event properties of the "GetUspsProofingResultsJob: Enrollment
status updated" analytic event.
@shanechesnutt-ft shanechesnutt-ft force-pushed the sc/LG-13715-add-eipp-prop-to-enrollment-status-updated-event branch from c29744d to f5b0147 Compare July 25, 2024 19:43
@shanechesnutt-ft shanechesnutt-ft merged commit c809120 into main Jul 25, 2024
@shanechesnutt-ft shanechesnutt-ft deleted the sc/LG-13715-add-eipp-prop-to-enrollment-status-updated-event branch July 25, 2024 20:07
mitchellhenke pushed a commit that referenced this pull request Jul 31, 2024
changelog: Internal, In-person proofing, Add enhanced_ipp property to
the event properties of the "GetUspsProofingResultsJob: Enrollment
status updated" analytic event.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants