LG-13715 Add enhanced_ipp to enrollment updated event#10962
Merged
shanechesnutt-ft merged 1 commit intomainfrom Jul 25, 2024
Merged
Conversation
97934c7 to
d0a881c
Compare
00a6998 to
4e4431e
Compare
Contributor
WilliamBirdsall
left a comment
There was a problem hiding this comment.
Followed testing scenarios successfully. LGTM
fa806cf to
7cb956d
Compare
7cb956d to
b26dce6
Compare
WilliamBirdsall
approved these changes
Jul 25, 2024
Contributor
WilliamBirdsall
left a comment
There was a problem hiding this comment.
Actually approved this time :)
b26dce6 to
c29744d
Compare
jennyverdeyen
approved these changes
Jul 25, 2024
Contributor
jennyverdeyen
left a comment
There was a problem hiding this comment.
Walked through the testing plan, logs looks great! Reviewed the code, everything looks good to me! Nice work!
changelog: Internal, In-person proofing, Add enhanced_ipp property to the event properties of the "GetUspsProofingResultsJob: Enrollment status updated" analytic event.
c29744d to
f5b0147
Compare
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 31, 2024
changelog: Internal, In-person proofing, Add enhanced_ipp property to the event properties of the "GetUspsProofingResultsJob: Enrollment status updated" analytic event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13715
🛠 Summary of changes
enhanced_ippto theproperties.event_propertiesof theGetUspsProofingResultsJob: Enrollment status updatedevent.📜 Testing Plan
Scenario:
EIPP -> USPS Proofing Passed -> Passed with unsupported Secondary ID - Logged
e = InPersonEnrollment.lastjson = JSON.parse(UspsInPersonProofing::Mock::Fixtures.request_passed_proofing_secondary_id_type_results_response)job = GetUspsProofingResultsJob.newjob.instance_variable_set('@enrollment_outcomes', { enrollments_passed: 0, enrollments_failed: 0 })job.send(:process_enrollment_response, e, res)property.event_properties.enhanced_ipp = trueEIPP -> USPS Proofing Passed -> Passed with Primary ID check - Logged
e = InPersonEnrollment.lastjson = JSON.parse(UspsInPersonProofing::Mock::Fixtures.request_passed_proofing_results_response)job = GetUspsProofingResultsJob.newjob.instance_variable_set('@enrollment_outcomes', { enrollments_passed: 0, enrollments_failed: 0 })job.send(:process_enrollment_response, e, res)property.event_properties.enhanced_ipp = trueID IPP -> USPS Proofing Passed -> Passed with unsupported secondary ID - Logged
e = InPersonEnrollment.lastjson = JSON.parse(UspsInPersonProofing::Mock::Fixtures.request_passed_proofing_secondary_id_type_results_response)job = GetUspsProofingResultsJob.newjob.instance_variable_set('@enrollment_outcomes', { enrollments_passed: 0, enrollments_failed: 0 })job.send(:process_enrollment_response, e, res)property.event_properties.enhanced_ipp = falseID IPP -> USPS Proofing Passed -> Passed with Primary ID check - Logged
e = InPersonEnrollment.lastjson = JSON.parse(UspsInPersonProofing::Mock::Fixtures.request_passed_proofing_results_response)job = GetUspsProofingResultsJob.newjob.instance_variable_set('@enrollment_outcomes', { enrollments_passed: 0, enrollments_failed: 0 })job.send(:process_enrollment_response, e, res)property.event_properties.enhanced_ipp = false