Merged
Conversation
changelog: Internal, Maintenance, Remove unused methods
mitchellhenke
commented
Jul 29, 2024
Comment on lines
-26
to
-29
| def stale_email_fingerprint? | ||
| Pii::Fingerprinter.stale?(email, email_fingerprint) | ||
| end | ||
|
|
mitchellhenke
commented
Jul 29, 2024
Comment on lines
-63
to
-65
| def self.security_url | ||
| URI.join(BASE_URL, locale_segment, 'security/').to_s | ||
| end |
Contributor
Author
There was a problem hiding this comment.
This was no longer used after #8508 and the URL is no longer correct either (login.gov/security now redirects to login.gov/policy)
zachmargolis
approved these changes
Jul 29, 2024
aduth
reviewed
Jul 30, 2024
| end | ||
|
|
||
| def stale_email_fingerprint? | ||
| Pii::Fingerprinter.stale?(email, email_fingerprint) |
Contributor
There was a problem hiding this comment.
The stale? method might now be unused after this method is removed?
Contributor
Author
There was a problem hiding this comment.
Pii::Fingerprinter.stale? is used elsewhere: https://github.com/18F/identity-idp/blob/e1b0db1c81eba880abb901c50b1885bb678ad95d/app/services/pii/cacher.rb#L61
Contributor
There was a problem hiding this comment.
Huh, I missed that one.
Okeydoke 👍
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 31, 2024
changelog: Internal, Maintenance, Remove unused methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This removes a couple unused methods that seem to be left over from past refactoring.