LG-13014: Implement password compromised#10861
Conversation
…ds are compromised to change their password
|
I was able to trigger the forced password change when signing in to http://localhost:3000 directly, but it did not show when signing in from the sample application. Can you check to make sure that works, since we should assume most users will be signing in to access a partner application? |
Follow-up: I paired with @mdiarra3 and this was an issue with how I was testing, and it does actually work as expected. The issue was due to how I was trying to reset the In case others have similar issues in testing, fixing it was a matter of changing from: To: |
aduth
left a comment
There was a problem hiding this comment.
I'm liking the new approach reusing the edit password controller 👍
aduth
left a comment
There was a problem hiding this comment.
A few minor remarks and a question, but LGTM overall 👍
| def aria_described_by_if_eligible | ||
| return {} if required_password_change? |
There was a problem hiding this comment.
Since we render the description for all views, do we need this condition anymore, or should we just always apply the aria-describedby ?
* changelog: Upcoming Features, Authentication, let users who's passwords are compromised to change their password * add password compromised spec and edit objects * sign in spec updated * change to use user_password_params * address comments * change up to use password controller * password compromised updates * fix lint and use global variable * update edit spec and global variable * fix the sign in spec * fix form spec * address comments, update test to better redirect * remove former check * make sure invalid password method is correct * Update to make aria described conditional * update specs and use hash format for attributes instead of positional arguments * fix reset password form spec * remove conditional for password strength description
🎫 Ticket
Link to the relevant ticket:
LG-13014
🛠 Summary of changes
This will Allow users to be notified that their password has been compromised and prompted to change their password.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
Steps to test
compromised_password_randomizer_valueandcompromised_password_randomizer_thresholdto 1 andcheck_user_password_compromised_enabledto true in the environment you are testing on.after_sign_in_pathfor user instead of password compromised page.👀 Screenshots