LG-13944 Add sponsor_id to initial IPP in-person enrollment creation#10984
Merged
shanechesnutt-ft merged 1 commit intomainfrom Jul 25, 2024
Merged
Conversation
47d45fd to
a7775c8
Compare
WilliamBirdsall
approved these changes
Jul 25, 2024
Contributor
WilliamBirdsall
left a comment
There was a problem hiding this comment.
Test Scenarios completed successfully. Code reviewed. Nice work!
jennyverdeyen
approved these changes
Jul 25, 2024
Contributor
jennyverdeyen
left a comment
There was a problem hiding this comment.
Went through the testing scenarios, code looks great! LGTM!
a7775c8 to
5e04412
Compare
changelog: Internal, In-person proofing, Set the sponsor_id field on in-person enrollments when they are created during the IPP usps location controller update request.
5e04412 to
d3aa980
Compare
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 31, 2024
…10984) changelog: Internal, In-person proofing, Set the sponsor_id field on in-person enrollments when they are created during the IPP usps location controller update request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-13944
🛠 Summary of changes
enrollment_helper.schedule_in_person_enrollmentmethod to check if a sponsor_id exists on the in-person enrollment before attempting to schedule a usps enrollment.📜 Testing Plan
Scenario: During EIPP flow when the user submits form for selecting a post office the in-person enrollment is saved with the configured EIPP sponsor_id.
/verify/document_capture#locationpage is reached.InPersonEnrollment.where(status: "establishing")Scenario: During ID-IPP flow when the user submits form for selecting a post office the in-person enrollment saved with the configured ID-IPP sponsor_id.
/verify/document_capture#locationpage is reached.InPersonEnrollment.where(status: "establishing")