Skip to content

LG-13944 Add sponsor_id to initial IPP in-person enrollment creation#10984

Merged
shanechesnutt-ft merged 1 commit intomainfrom
sc/LG-13944-ensure-enrollments-have-sponsor-id
Jul 25, 2024
Merged

LG-13944 Add sponsor_id to initial IPP in-person enrollment creation#10984
shanechesnutt-ft merged 1 commit intomainfrom
sc/LG-13944-ensure-enrollments-have-sponsor-id

Conversation

@shanechesnutt-ft
Copy link
Contributor

@shanechesnutt-ft shanechesnutt-ft commented Jul 24, 2024

🎫 Ticket

Link to the relevant ticket:
LG-13944

🛠 Summary of changes

  • Set the sponsor_id field on in-person enrollments when they are created during the IPP usps location controller update request.
  • Updated the enrollment_helper.schedule_in_person_enrollment method to check if a sponsor_id exists on the in-person enrollment before attempting to schedule a usps enrollment.

📜 Testing Plan

Scenario: During EIPP flow when the user submits form for selecting a post office the in-person enrollment is saved with the configured EIPP sponsor_id.

  • Login through the oidc sinatra application selecting the Enhanced In-person Proofing level of service.
  • Use an exisiting account or create an account
  • Continue through the In-person flow until the /verify/document_capture#location page is reached.
  • Open the Rails Console
  • Verify that no establishing enrollments exist for the current user InPersonEnrollment.where(status: "establishing")
  • Search for participating post office and select one
  • Verify that the establishing enrollment exists and has the sponsor_id set to the configured EIPP sponsor_id
  • Complete the flow and ensure no issues

Scenario: During ID-IPP flow when the user submits form for selecting a post office the in-person enrollment saved with the configured ID-IPP sponsor_id.

  • Login through the oidc sinatra application selecting a non Enhanced In-person Proofing level of service.
  • Use an exisiting account or create an account
  • Continue through the In-person flow until the /verify/document_capture#location page is reached.
  • Open the Rails Console
  • Verify that no establishing enrollments exist for the current user InPersonEnrollment.where(status: "establishing")
  • Search for participating post office and select one
  • Verify that the establishing enrollment exists and has the sponsor_id set to the configured ID-IPP sponsor_id
  • Complete the flow and ensure no issues

@shanechesnutt-ft shanechesnutt-ft force-pushed the sc/LG-13944-ensure-enrollments-have-sponsor-id branch 2 times, most recently from 47d45fd to a7775c8 Compare July 24, 2024 22:07
@shanechesnutt-ft shanechesnutt-ft requested review from a team and WilliamBirdsall July 25, 2024 14:09
@shanechesnutt-ft shanechesnutt-ft marked this pull request as ready for review July 25, 2024 14:16
Copy link
Contributor

@WilliamBirdsall WilliamBirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Scenarios completed successfully. Code reviewed. Nice work!

@jennyverdeyen jennyverdeyen self-requested a review July 25, 2024 16:45
Copy link
Contributor

@jennyverdeyen jennyverdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the testing scenarios, code looks great! LGTM!

@shanechesnutt-ft shanechesnutt-ft force-pushed the sc/LG-13944-ensure-enrollments-have-sponsor-id branch from a7775c8 to 5e04412 Compare July 25, 2024 17:47
changelog: Internal, In-person proofing, Set the sponsor_id field on
in-person enrollments when they are created during the IPP usps location
controller update request.
@shanechesnutt-ft shanechesnutt-ft force-pushed the sc/LG-13944-ensure-enrollments-have-sponsor-id branch from 5e04412 to d3aa980 Compare July 25, 2024 18:18
@shanechesnutt-ft shanechesnutt-ft merged commit 3697dab into main Jul 25, 2024
@shanechesnutt-ft shanechesnutt-ft deleted the sc/LG-13944-ensure-enrollments-have-sponsor-id branch July 25, 2024 18:55
mitchellhenke pushed a commit that referenced this pull request Jul 31, 2024
…10984)

changelog: Internal, In-person proofing, Set the sponsor_id field on
in-person enrollments when they are created during the IPP usps location
controller update request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants