Remove file that is not in use [skip changelog]#10991
Merged
eileen-nava merged 2 commits intomainfrom Jul 26, 2024
Merged
Conversation
Contributor
|
For posterity, @vrajmohan found that the file that used this was seemingly removed in e9290e3 which adds further confidence for me that we can safely remove this. |
zachmargolis
approved these changes
Jul 26, 2024
| @@ -1,8 +0,0 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class MultipleMfaOptionsValidator < ActiveModel::EachValidator | |||
Contributor
There was a problem hiding this comment.
I think this became unused in #9788 when PhoneDeletionForm was removed
Contributor
There was a problem hiding this comment.
Great minds (you and Vraj) think alike! 😜
Contributor
jinx! |
n1zyy
approved these changes
Jul 26, 2024
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
Assuming tests pass, 
-- thanks for running with this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today during rspec league, we were looking at adding test coverage for files that have no test coverage. Then we found that this file isn't in use anywhere. Consequently, we decided to delete it. Fin.