LG-13663: recaptcha sign in failure page#10944
Conversation
|
This will need to be in a holding pattern until the PR on identity-site page for this is made and merged in or else users will be taken to an error page in identity-site. |
I think we'd planned to code this with the expected URL even if it doesn't exist today, since the feature isn't enabled for live users anyways. |
Oh good, Then ignore me, |
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Couple minor comments, LGTM otherwise
spec/controllers/sign_in_security_check_failed_controller_spec.rb
Outdated
Show resolved
Hide resolved
spec/controllers/sign_in_security_check_failed_controller_spec.rb
Outdated
Show resolved
Hide resolved
| security_check_failed.contact: Contact %{app_name} support | ||
| security_check_failed.details: We don’t recognize the device or browser you’re signing in from. | ||
| security_check_failed.info_p1: 'Use the same device and browser you created your %{app_name} account with.' | ||
| security_check_failed.info_p2_html: Try <a href="%{piv_cac_url}">signing in with your government employee ID</a> if you are a government employee. |
There was a problem hiding this comment.
IMO I think it might be a little more reliable to get things through the i18n process to break the link title into its own key
| security_check_failed.info_p2_html: Try <a href="%{piv_cac_url}">signing in with your government employee ID</a> if you are a government employee. | |
| security_check_failed.info_p2_html: Try %{piv_cac_link_html} if you are a government employee. | |
| security_check_failed.info_p2_link_html: signing in with your government employee ID |
and then update the callsite to be like
<li><%= t('security_check_failed.info_p2_html', piv_cac_link_html: link_to(t('security_check_failed.info_p2_link_html'), login_piv_cac_url) %></li> 
* changelog: Upcoming Features, Authentication, Recaptcha Sign in * fix spec * add test to ensure user redirected to security check failed * add additional languges and page * address comments * lint fix * address comments * use c * fix failed * sign in security check controller spec added * change spec name * use back instead of cancel * update security check failed spec
3 participants
🎫 Ticket
Link to the relevant ticket:
LG-13663
🛠 Summary of changes
Adds page for users that fail sign in check.
📜 Testing Plan
Screenshot