Conversation
changelog: Internal, Automated Testing, Fix flakey IAA Agreements spec
zachmargolis
approved these changes
Jul 26, 2024
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 31, 2024
changelog: Internal, Automated Testing, Fix flakey IAA Agreements spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates the spec for
Agreements::Iaato fix flakey test failures.Example failure: https://gitlab.login.gov/lg/identity-idp/-/jobs/1326656
The issue is that the spec in question compares a factory-created record with a randomized order number with a record that has a set order number. And because the randomized order number is between 1 and 1000, this leaves a 1 in 1000 chance that the number conflicts.
The fix is to assign a unique, known
order_numberto the "other" record. Another option is to use a dynamically-generated order number for both and use Faker's.uniqueoption, but this adds some complexity to how other specs in this file assert their expected result (example).📜 Testing Plan
Verify build passes.