Merged
Conversation
zachmargolis
approved these changes
Jul 24, 2024
changelog: Internal, Code Quality, Sort keys in application.yml.default
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
force-pushed
the
aduth-application-yaml-sort
branch
from
e293891 to
195f954
Compare
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 31, 2024
* normalize-yaml: Add option to ignore keys in sorting * Sort keys in application.yml.default changelog: Internal, Code Quality, Sort keys in application.yml.default * Clarify ignore key sort option in README * Add spec for ignoreKeySort * Improve formatting for original and expected output Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Fix comment annotation arrangement --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates
normalize-yamlto support the ability to ignore sorting for specific keys, and applies key sorting toapplication.yml.default.Why?
📜 Testing Plan
application.yml.default.make normalize_yamlapplication.yml.defaultare sorted