LG-13599 Failed doc auth result offers IPP offramp#10903
Conversation
changelog: User-Facing Improvements, Doc Auth, Failed doc auth offers IPP offramp
| <DocumentCaptureTroubleshootingOptions | ||
| location="post_submission_warning" | ||
| showAlternativeProofingOptions={!isFailedResult} | ||
| showAlternativeProofingOptions |
There was a problem hiding this comment.
It looks like showAlternativeProofingOptions is true in all cases now. Should we get rid of the prop altogether?
There was a problem hiding this comment.
Yeah. Checking out where else it is used, we don't need it anymore. I will remove it
since we offer IPP offramp for failed doc_auth we do not need this check anymore
| }); | ||
|
|
||
| context('with showAlternativeProofingOptions', () => { | ||
| it('renders in-person call to action', () => { |
There was a problem hiding this comment.
I'm confused by the mismatch between the test description and the assertion to render something. Should we have at least one test that the expected content is always rendered now?
There was a problem hiding this comment.
That test is below. With in person url -> it renders in-person call to action. This test is without in-person url -> it does not render ipp cta. This test probably was mis-named before.
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I can't speak to business logic, but code LGTM 👍
* Failed doc auth result offers IPP offramp changelog: User-Facing Improvements, Doc Auth, Failed doc auth offers IPP offramp * remove showAlternativeProofingOptions since we offer IPP offramp for failed doc_auth we do not need this check anymore
3 participants
🎫 Ticket
Link to the relevant ticket:
LG-13599
🛠 Summary of changes
When a user goes through doc auth and gets a failed doc auth result, they are now offered the option to go through In-Person Proofing.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
spec/fixtures/ial2_test_credential_doc_auth_fail_and_no_liveness.yml)