Stuttering0et patch11 merge#1
Merged
stutteringp0et merged 255 commits intostutteringp0et:patch-11from May 4, 2019
Merged
Conversation
* Move duplicated code to the PrivacyPlugin * Code style
* Add action log plugin library class * Double * * register instead of import
This language string created by the JSST is not correct - see the style guide https://developer.joomla.org/en-gb-user-interface-text-guidelines/action-or-description.html
* Fix wrong action log link when add/edit article * Add @SInCE tag * Correct codestyle
* Sort log extensions * Case insensitive * Workaround. Thanks @mbabker.
Summary of Changes Removal of a redundant comment. Testing Instructions Code review to confirm it's not needed in the distribution.
… a (joomla#22518) module in frontend
* Don't delete 3rd party license file * Don't delete 3rd party license file * Add back deleted dir file
…led/default_ftp.php (joomla#22646) dont delete /administrator/templates/hathor/html/com_languages/installed/default_ftp.php joomla#22580 (comment)
even though that means its there just for 3pd b/c until joomla 4
…#22655) s/Form Field to load a list of content authors/Field to load a list of all extensions that have logged actions/ Use "Field to load a list of all users that have logged actions" which was the text in the form field for the extension dropdown as that makes more sense here, I have already corrected the extensions dropdown text too
simple copy and paste typo
* s/Referer/Referrer-Policy/ > Note that Referer is actually a misspelling of the word "referrer". The Referrer-Policy header does not share this misspelling. (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Referrer-Policy) Here we are referring to Referrer-Policy and not the `referrer` header
correct english plural
J4 version of joomla#23499 It is very common to need to display a unit of measurement/value with a field. Currently there is no way to do this without creating custom layouts for every field and every unit when needed. This PR adds two new param to every custom field "Suffix" and "Prefix" which allows you to add a unit of measurement (or any other text) to be rendered after/before the value of the field.
This is a little hard to test. Step 1 open a module (make sure it opened on the first tab - if not move to first tab, close the module and start again) Step 2 view source and locate the code shown in the image below You will see that 1. all the <section have aria-hidden=true 2. the first has class="active" and the rest have an empty class Step 3 close the module and apply the patch and locate the code shown in the image below You will see that 1. the first <section has an attribute of "active" and the rest do not 2. all but the first <section have aria-hidden=true 3. none of the <section have a class
* Fix tags creation * Codestyle
This is for the options screens for all components. ie the view you get when you click on the options button. This PR should have no visible impact. It just changes from rendering the input and label as individual items to rendering it as a field which is what we do (almost) everywhere else
The title is supposed to change as the content is being indexed but it doesn't because of a silly little typo This PR fixes that. You can easily test this by running the indexer and without this PR you will see that it always says "Starting Indexer" After applying this PR you will see the title change
The popup that is loaded when you index the content has a message that is updated during the index process COM_FINDER_INDEXER_MESSAGE_INIT="The indexer is starting. Do not close this window." COM_FINDER_INDEXER_MESSAGE_RUNNING="Your content is being indexed. Do not close this window." COM_FINDER_INDEXER_MESSAGE_OPTIMIZE="The index tables are being optimised for the best possible performance. Do not close this window." COM_FINDER_INDEXER_MESSAGE_COMPLETE="The indexing process is complete. It is now safe to close this window." This changing message is invisible to screen readers unless we add an aria-live attribute to the enclosing element. Normally we would have aria-live=polite but in this case there is nothing else on the screen so aria-live=assertive is appropriate
It is part of the a11y requirements to ensure that an iframe has a title attribute This simple PR fixes that for the modal iframe layout
We don't need the <strong wrapping the item as it is now a th and that gives it a font weight of 700 already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for PR joomla#24550
Summary of Changes
Merge to latest 4.0-dev branch
For SQL issue in menu item edit form if we add the filter_tag. Tags filters in frontend seems to works fine.
Testing Instructions