Add a redirection for the menu item alias#22432
Conversation
|
I have tested this item ✅ successfully on 8c5c907 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22432. |
|
I have tested this item ✅ successfully on 8c5c907 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22432. |
|
@mbabker |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22432. |
|
This change has unwanted consequences for us... An alias is not always necessarily a redirect. We are using aliases on purpose and don't want to have a 301 redirect for it (otherwise we would have created a redirect). An example: we generate AMP-equivalents of pages by using the Alias menu-item. Thanks to the "Template Style" setting of the alias menu-item we can load a different (amp-focussed) template for that page. So e.g.:
Joomla 3.8.13: Joomla 3.9.0: If the "alias" should be considered as "redirect" after this patch, I don't see why we are still offering options for selecting the template style. I do think we have two options here: |
|
I like point 2 more, but I'm not sure if the field label "Redirect" will be understandable. |
|
This change affects our site as well. We are using a similar set-up as @sanderpotjer describes. Option 2 should fix this change for sure. |
|
I will try to prepare a new PR with option 2 |
|
This change broke our site. Extensions using jQuery.ajax method like: jQuery.ajax({
context:this,
url: 'index.php?option=com_mycomponent&task=mycontroller.method&format=raw',
dataType: 'json',
data: {start: start.format(),end: end.format()},
success: function(doc) {
// Do something
}
});Are now causing a redirection. It also happens with POST requests. I know using urls in javascript without using the routing system are not technically ok but they are actually used by extensions and this breaks things. I had to "hack" core to revert this. |
|
Proposed solution at #23278 |
Pull Request for Issue #19340 and #19624
Summary of Changes
Proposal to solve problems.
Testing Instructions
See issues.
Expected result
When you go to the link that is an alias then you will be redirected to the correct page.
Actual result
You remain on a page of the menu item alias.