Skip to content

[3.9.0] No need to escape PLG_QUICKICON_PRIVACYCHECK language strings values#22557

Merged
mbabker merged 1 commit intojoomla:stagingfrom
infograf768:escapeprivacy
Oct 9, 2018
Merged

[3.9.0] No need to escape PLG_QUICKICON_PRIVACYCHECK language strings values#22557
mbabker merged 1 commit intojoomla:stagingfrom
infograf768:escapeprivacy

Conversation

@infograf768
Copy link
Member

Pull Request for Issue #22549

Summary of Changes

As title says

Testing Instructions

Add some single quotes in the administrator/language/en-GB/en-GB.plg_quickicon_privacycheck.ini
Create a privacy request. Load cpanel

Before patch

screen shot 2018-10-08 at 12 10 20

screen shot 2018-10-08 at 12 10 26

After patch

screen shot 2018-10-09 at 09 30 53

screen shot 2018-10-09 at 09 31 00

@infograf768
Copy link
Member Author

Note: for j4, would be nice to normalize the quickicon plugins code.

@richard67
Copy link
Member

I have tested this item ✅ successfully on e0482d0

Was a bit tricky to get an urgent privacy request for testing, but finally I managed it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22557.

@Quy
Copy link
Contributor

Quy commented Oct 9, 2018

I have tested this item ✅ successfully on e0482d0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22557.

@Quy
Copy link
Contributor

Quy commented Oct 9, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22557.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit PR-staging and removed PR-staging RTC This Pull Request is Ready To Commit labels Oct 9, 2018
@infograf768 infograf768 deleted the escapeprivacy branch October 10, 2018 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants