Merged
Conversation
This is a little hard to test. Step 1 open a module (make sure it opened on the first tab - if not move to first tab, close the module and start again) Step 2 view source and locate the code shown in the image below You will see that 1. all the <section have aria-hidden=true 2. the first has class="active" and the rest have an empty class Step 3 close the module and apply the patch and locate the code shown in the image below You will see that 1. the first <section has an attribute of "active" and the rest do not 2. all but the first <section have aria-hidden=true 3. none of the <section have a class
Quy
reviewed
Apr 23, 2019
Co-Authored-By: brianteeman <brian@teeman.net>
Contributor
|
Check with dimitris and he confirmed this is correct. Thanks! |
Contributor
Author
|
/me wipes brow |
fancyFranci
pushed a commit
to fancyFranci/joomla-cms
that referenced
this pull request
Apr 24, 2019
This is a little hard to test. Step 1 open a module (make sure it opened on the first tab - if not move to first tab, close the module and start again) Step 2 view source and locate the code shown in the image below You will see that 1. all the <section have aria-hidden=true 2. the first has class="active" and the rest have an empty class Step 3 close the module and apply the patch and locate the code shown in the image below You will see that 1. the first <section has an attribute of "active" and the rest do not 2. all but the first <section have aria-hidden=true 3. none of the <section have a class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a little hard to test. You must always be testing by opening a module - refresh doesnt work
Step 1 open a module (make sure it opened on the first tab - if not move to first tab, close the module and start again)
Step 2 view source and locate the code shown in the image below
You will see that
Step 3 close the module and apply the patch and repeat step 1 and 2
Now You will see that