Skip to content

[4.0] Add tag filter to category list#24550

Closed
stutteringp0et wants to merge 12 commits intojoomla:4.0-devfrom
stutteringp0et:patch-11
Closed

[4.0] Add tag filter to category list#24550
stutteringp0et wants to merge 12 commits intojoomla:4.0-devfrom
stutteringp0et:patch-11

Conversation

@stutteringp0et
Copy link
Contributor

@stutteringp0et stutteringp0et commented Apr 10, 2019

#24398 requested the tag filter option available in Category Blog be made available in Category List. This simple XML change is the only thing necessary to accomplish this request.

Pull Request for Issue # .

Summary of Changes

Simple XML change to the Category List (default.xml) enables tag filtering

Testing Instructions

Create several articles in the same category using various tags
Create several Category List menu items for the category using the various tags used previously

Expected result

Tag filtered Category List

Actual result

Works for me

Documentation Changes Required

joomla#24398 requested the tag filter option available in Category Blog be made available in Category List.  This simple XML change is the only thing necessary to accomplish this request.
@ghost ghost changed the title Add tag filter to category list on issue #24398 [4.0] Add tag filter to category list on issue #24398 Apr 10, 2019
@ghost ghost added the J4 Issue label Apr 10, 2019
@ghost
Copy link

ghost commented Apr 11, 2019

@rytechsites please test as Opener of #24398. how to test: https://docs.joomla.org/Testing_Joomla!_patches

@ghost ghost changed the title [4.0] Add tag filter to category list on issue #24398 [4.0] Add tag filter to category list Apr 11, 2019
@ghost ghost removed the J4 Issue label Apr 13, 2019
@fastslack
Copy link
Contributor

@test Filters seems to works fine using this PR stutteringp0et#1

@sanderpotjer
Copy link
Member

I have tested this item 🔴 unsuccessfully on caf6974

This needs a fix as suggested by merging PR of @fastslack "Fix SQL issue for ajax search" into this PR.

Also: When a tag is removed the "old" tag is still in the Joomla state, so only in a new session the user will see all articles for a category again. Would be nice to make sure that if no tag is selected this is directly forced in the state.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24550.

@stutteringp0et
Copy link
Contributor Author

I can find no PR titled "Fix SQL issue for ajax search" and none of @fastslack 's PR's match that description.

Is there a # I can look up?

@fastslack
Copy link
Contributor

Is there a # I can look up?

35b1163

@ghost ghost added the Conflicting Files label Jun 23, 2019
@stutteringp0et
Copy link
Contributor Author

How do I resolve the conflicts?

@ghost
Copy link

ghost commented Jul 22, 2019

@stutteringp0et
Copy link
Contributor Author

Thank you for pointing me in the right direction @franz-wohlkoenig

@stutteringp0et
Copy link
Contributor Author

This needs, what - 2 more human tests?

@ghost
Copy link

ghost commented Jul 23, 2019

This needs, what - 2 more human tests?

Yes. After 2 successfully Tests Release Lead decide if merge.

@stutteringp0et
Copy link
Contributor Author

@fastslack do you mind testing again?
@rytechsites this is on your request, can you test?

@rytechsites
Copy link

I would be interested in testing this. Can someone tell me the exact 'joomla 4' version I should download that includes this fix? I'm sorry for my ignorance, I haven't tested in this way before.

Thanks again for getting this done!

-- Laura

@alikon
Copy link
Contributor

alikon commented Jul 23, 2019

i think you should download & install the nigthly build from here https://developer.joomla.org/nightly-builds.html which doesn't include this pr and then install the com_patchtester a guide for using patchtester https://docs.joomla.org/Component_Patchtester_for_Testers

@rytechsites
Copy link

rytechsites commented Jul 23, 2019 via email

@tushar33
Copy link

I have tested this item 🔴 unsuccessfully on b96957d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24550.

3 similar comments
@pravinTek
Copy link

I have tested this item 🔴 unsuccessfully on b96957d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24550.

@shinderohanoffical
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on b96957d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24550.

@SharayuYadav
Copy link

I have tested this item 🔴 unsuccessfully on b96957d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24550.

@HLeithner
Copy link
Member

Since this is a missing xml field I would accept this als backport for j3 if someone is interested to do this.

@roland-d
Copy link
Contributor

roland-d commented Aug 1, 2020

@stutteringp0et This has been awhile but I think the failed tests come from the file conflict. Could you fix the conflict please?

@Quy
Copy link
Contributor

Quy commented Aug 26, 2020

Ported from J3 in PR #27596

@Quy Quy closed this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.