[3.9.0] correcting action log link when module is saved in frontend#22545
Merged
infograf768 merged 1 commit intojoomla:stagingfrom Oct 9, 2018
Merged
[3.9.0] correcting action log link when module is saved in frontend#22545infograf768 merged 1 commit intojoomla:stagingfrom
infograf768 merged 1 commit intojoomla:stagingfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 24b5db4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22545. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 24b5db4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22545. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22545. |
Contributor
|
This looks like a dirty fix for me. When a module is saved from frontend, the context is com_modules.module. I wonder if we should get $option directly from first part of context instead of getting it from input? The same could be applied for $option from other methods in the plugin. Thought? |
Member
Author
|
If we do that, it should indeed be done globally. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #22532
Summary of Changes
When saving a module in frontend, the link created wrongly uses
com_configin the url.This PR checks the $table to get
com_moduleswhich is the right$optionin this case.Testing Instructions
See #22532
@alikon