Skip to content

[3.9.0] correcting action log link when module is saved in frontend#22545

Merged
infograf768 merged 1 commit intojoomla:stagingfrom
infograf768:actionlogsmodules
Oct 9, 2018
Merged

[3.9.0] correcting action log link when module is saved in frontend#22545
infograf768 merged 1 commit intojoomla:stagingfrom
infograf768:actionlogsmodules

Conversation

@infograf768
Copy link
Member

Pull Request for Issue #22532

Summary of Changes

When saving a module in frontend, the link created wrongly uses com_config in the url.
This PR checks the $table to get com_modules which is the right $option in this case.

Testing Instructions

See #22532

@alikon

@Quy
Copy link
Contributor

Quy commented Oct 8, 2018

I have tested this item ✅ successfully on 24b5db4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22545.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Oct 8, 2018

I have tested this item ✅ successfully on 24b5db4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22545.

@Quy
Copy link
Contributor

Quy commented Oct 8, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22545.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 8, 2018
@infograf768 infograf768 merged commit 9c04b63 into joomla:staging Oct 9, 2018
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Oct 9, 2018
@joomdonation
Copy link
Contributor

This looks like a dirty fix for me. When a module is saved from frontend, the context is com_modules.module. I wonder if we should get $option directly from first part of context instead of getting it from input? The same could be applied for $option from other methods in the plugin. Thought?

@infograf768 infograf768 deleted the actionlogsmodules branch October 9, 2018 15:43
@zero-24 zero-24 added this to the Joomla 3.9.0 milestone Oct 9, 2018
@infograf768
Copy link
Member Author

If we do that, it should indeed be done globally.
A bit late for 3.9.0 (RC today). Maybe for 3.9.1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants