Conversation
This is for the options screens for all components. ie the view you get when you click on the options button. This PR should have no visible impact. It just changes from rendering the input and label as individual items to rendering it as a field which is what we do (almost) everywhere else
|
Updating branch to trigger drone |
|
@zero-24 can you look at RIPS for me please |
|
updated to include global config |
| </div> | ||
| <?php echo $field->renderField(); ?> | ||
| <?php else : ?> | ||
| <?php echo $this->form->getInput('rules'); ?> |
There was a problem hiding this comment.
So it looks like we removed the controls class on the input before. Is that a issue here :/ Because if it's just hiding the label we can do that at the xml level and have no crazy exceptions here
There was a problem hiding this comment.
Yes this pr is about hiding the label and yes it can be done in the xml but it would have to be done for every switcher field in every xml afaict
There was a problem hiding this comment.
Our if statement here is based on whether the field is called permissions. That's much more specific than a switcher field?
There was a problem hiding this comment.
Test it and see if it works. Always happy to accept better code.
Drone restarted: http://ci.joomla.org/joomla/joomla-cms/17428 |
| @@ -80,13 +80,10 @@ | |||
| <?php else : ?> | |||
| <div class="control-group<?php echo $groupClass; ?>"<?php echo $dataShowOn; ?>> | |||
There was a problem hiding this comment.
This doesn't work on testing. We're getting nested control groups. Because we get one on this line and one when we call renderField
There was a problem hiding this comment.
Screenshot. Admittedly it renders ok. but clearly not correct
There was a problem hiding this comment.
Done a PR to your branch for this
There was a problem hiding this comment.
When I recover from man flu I will take a look
|
Thanks! |
|
Thanks |
4 participants
This is for the options screens for all components. ie the view you get when you click on the options button and for global config
This PR should have no visible impact. It just changes from rendering the input and label as individual items to rendering it as a field which is what we do (almost) everywhere else