[4.0] Fix schema updates for com_finder with PostgreSQL database#24771
Merged
wilsonge merged 6 commits intojoomla:4.0-devfrom May 3, 2019
Merged
[4.0] Fix schema updates for com_finder with PostgreSQL database#24771wilsonge merged 6 commits intojoomla:4.0-devfrom
wilsonge merged 6 commits intojoomla:4.0-devfrom
Conversation
Member
Author
|
@alikon Could you test? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771. |
Member
Author
|
Drone failure is not related to this PR. Phpcs was successful. It was the prepare step which failed. |
Member
Author
|
@twister65 I noticed you test with PostgreSQL, too. If you have time, could you test my PR here? Thanks in advance if so. |
Member
Author
|
Drone failure again is not related to this PR. Phpcs was successful. This time it was analysis4x which failed. |
Contributor
|
I have tested this item ✅ successfully on 74bc831 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771. |
Contributor
|
I have tested this item ✅ successfully on 9b46955 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771. |
Contributor
|
@zero-24 @SniperSister rips please |
Member
Author
|
@wilsonge What means "rips"? Rest in pieces? ;-) |
Contributor
|
It’s the tool we use for the security analysis part of drone (which was failing). It’s now passing so I can merge this! Thanks! |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #24769 .
Summary of Changes
Fix the schema update changes from PR #20561 for PostgreSQL so they are consistent with a new installation.
Testing Instructions
composer installandnpm ci, or use nightly build from tonight. Both include PR [4.0] installation with postgresql #24747, which is needed to install on PostgreSQL. Alpha 8 does not include that yet, so please don't use Alpha 8.Expected result
No database problems.
Actual result
Documentation Changes Required
None.