Skip to content

[4.0] Fix schema updates for com_finder with PostgreSQL database#24771

Merged
wilsonge merged 6 commits intojoomla:4.0-devfrom
richard67:4.0-dev-fix-finder-pgsql-1
May 3, 2019
Merged

[4.0] Fix schema updates for com_finder with PostgreSQL database#24771
wilsonge merged 6 commits intojoomla:4.0-devfrom
richard67:4.0-dev-fix-finder-pgsql-1

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented May 1, 2019

Pull Request for Issue #24769 .

Summary of Changes

Fix the schema update changes from PR #20561 for PostgreSQL so they are consistent with a new installation.

Testing Instructions

  1. Pull current (May 1, 2019) 4.0-dev branch and do composer install and npm ci, or use nightly build from tonight. Both include PR [4.0] installation with postgresql #24747, which is needed to install on PostgreSQL. Alpha 8 does not include that yet, so please don't use Alpha 8.
  2. Run installation using a PostgreSQL database.
  3. After installation has finished with success, login to backend, confirm the statistics dialog, then goto the system panel and check section "Information - Database". Result: You see that there is 1 database problem.
  4. Click "Database" to get to the Database view. Result: See section "Actual result" below.
  5. Apply changes from this PR.
  6. Leave database view and go back to it again. Result: See section "Expected result" below.

Expected result

No database problems.

Actual result

screen shot 2019-05-01 at 09 59 15

Documentation Changes Required

None.

@richard67
Copy link
Member Author

@alikon Could you test?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771.

@richard67
Copy link
Member Author

Drone failure is not related to this PR. Phpcs was successful. It was the prepare step which failed.

@richard67
Copy link
Member Author

@twister65 I noticed you test with PostgreSQL, too. If you have time, could you test my PR here? Thanks in advance if so.

@richard67
Copy link
Member Author

Drone failure again is not related to this PR. Phpcs was successful. This time it was analysis4x which failed.

@twister65
Copy link
Contributor

I have tested this item ✅ successfully on 74bc831

Tested with Joomla_4.0.0-alpha9-dev nightly build.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771.

@alikon
Copy link
Contributor

alikon commented May 2, 2019

I have tested this item ✅ successfully on 9b46955


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771.

@alikon
Copy link
Contributor

alikon commented May 2, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24771.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 2, 2019
@wilsonge
Copy link
Contributor

wilsonge commented May 2, 2019

@zero-24 @SniperSister rips please

@richard67
Copy link
Member Author

richard67 commented May 3, 2019

@wilsonge What means "rips"? Rest in pieces? ;-)

@wilsonge wilsonge merged commit 57510c1 into joomla:4.0-dev May 3, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 3, 2019
@wilsonge
Copy link
Contributor

wilsonge commented May 3, 2019

It’s the tool we use for the security analysis part of drone (which was failing). It’s now passing so I can merge this! Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone May 3, 2019
@richard67
Copy link
Member Author

Thanks!

@richard67 richard67 deleted the 4.0-dev-fix-finder-pgsql-1 branch May 3, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants