Skip to content

[com_actionlogs] Sort events in alpha order#22542

Merged
mbabker merged 3 commits intojoomla:stagingfrom
SharkyKZ:logtype
Oct 9, 2018
Merged

[com_actionlogs] Sort events in alpha order#22542
mbabker merged 3 commits intojoomla:stagingfrom
SharkyKZ:logtype

Conversation

@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Oct 8, 2018

Pull Request for Issue #22533.

Summary of Changes

This sorts loggable extensions alphabetically.

Testing Instructions

Go to System > Global Configuration > User Actions Log

Expected result

Extensions sorted alphabetically.

Actual result

Articles and Check-in are not in alpha order.

Documentation Changes Required

No.

@Quy
Copy link
Contributor

Quy commented Oct 8, 2018

Here is the new sort:

Redirects
Tags
News Feeds
Plugins
Messaging
Modules Manager
Media
Cache
Articles
Installer
Contacts
Configuration Manager
Categories
Templates
Menus
Users
Banners

@mbabker
Copy link
Contributor

mbabker commented Oct 8, 2018

It needs the same kind of handling that we use for the list of components in com_config for the sidebar.

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Oct 8, 2018

I was able to reproduce @Quy's result on Windows but not on Linux. There seems to be some issues with setting locale on Windows.

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Oct 8, 2018

@mbabker PR updated with your suggestion. @Quy can you retest, please.

@Quy
Copy link
Contributor

Quy commented Oct 8, 2018

I have tested this item ✅ successfully on 2204cd1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22542.

1 similar comment
@csthomas
Copy link
Contributor

csthomas commented Oct 9, 2018

I have tested this item ✅ successfully on 2204cd1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22542.

@infograf768
Copy link
Member

Will set RTC, but how is it that I do not have check-in in the list?

@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/22542.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 9, 2018
@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Oct 9, 2018

Check-in is from a pending PR. But Articles is out of order even without it.

@infograf768
Copy link
Member

Yeah, Articles is correct now indeed

@infograf768
Copy link
Member

hmm drone has issues...can't even relaunch it

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants